[Home]

Summary:ASTERISK-11665: Update phones 'Placed Call' log when using a local analog channel
Reporter:dea (dea)Labels:
Date Opened:2008-03-17 12:05:53Date Closed:2008-03-17 13:07:14
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_skinny-call-log.txt
Description:Skinny phones can track and display a call log of Placed, Missed and received
calls.

Normally the call log is updated within skinny_indicate, which works just
fine if the peer channel reports progress.  It works less well if the peer
channels is a local analog ZAP port.

The following patch is a one-liner that adds an update to the Placed call
log in skinny_answer.  When placing a call to a channel that does report
progress, we will get a call log update in skinny_indicate whether the peer
channel answer or not (which is the desired outcome), and in skinny_answer
if the peer channels does answer.  The phones handle the redudnant update
without generating duplicate entries.

Comments:By: Digium Subversion (svnbot) 2008-03-17 12:39:37

Repository: asterisk
Revision: 109168

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r109168 | mvanbaak | 2008-03-17 12:39:36 -0500 (Mon, 17 Mar 2008) | 11 lines

Update the directory of placed calls on skinny phones
when dialing a channel that does not provide progress (analog ZAP lines)

The phone does handle the double update on calls to channels that do
provide progress and wont insert duplicate items

(closes issue ASTERISK-11665)
Reported by: DEA
Patches:
     chan_skinny-call-log.txt uploaded by DEA (license 3)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=109168
By: Digium Subversion (svnbot) 2008-03-17 12:51:34

Repository: asterisk
Revision: 109171

U   branches/1.4/channels/chan_skinny.c

------------------------------------------------------------------------
r109171 | mvanbaak | 2008-03-17 12:51:25 -0500 (Mon, 17 Mar 2008) | 11 lines

Update the directory of placed calls on skinny phones                                                                                                                                                            
when dialing a channel that does not provide progress (analog ZAP lines)                                                                                                                                          
                                                                                                                                                                                                                 
The phone does handle the double update on calls to channels that do                                                                                                                                              
provide progress and wont insert duplicate items                                                                                                                                                                  
                                                                                                                                                                                                                 
(closes issue ASTERISK-11665)                                                                                                                                                                                            
Reported by: DEA                                                                                                                                                                                                  
Patches:                                                                                                                                                                                                          
     chan_skinny-call-log.txt uploaded by DEA (license 3)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=109171
By: Digium Subversion (svnbot) 2008-03-17 13:07:14

Repository: asterisk
Revision: 109175

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_skinny.c

------------------------------------------------------------------------
r109175 | mvanbaak | 2008-03-17 13:07:09 -0500 (Mon, 17 Mar 2008) | 19 lines

Merged revisions 109168 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r109168 | mvanbaak | 2008-03-17 18:43:46 +0100 (Mon, 17 Mar 2008) | 11 lines

Update the directory of placed calls on skinny phones
when dialing a channel that does not provide progress (analog ZAP lines)

The phone does handle the double update on calls to channels that do
provide progress and wont insert duplicate items

(closes issue ASTERISK-11665)
Reported by: DEA
Patches:
     chan_skinny-call-log.txt uploaded by DEA (license 3)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=109175