[Home]

Summary:ASTERISK-11642: [patch] Added event based MWI to chan_skinny
Reporter:dea (dea)Labels:
Date Opened:2008-03-14 10:59:33Date Closed:2008-04-27 10:15:29
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_skinny-vm-events.txt
( 1) chan_skinny-vm-events-v2.txt
( 2) chan_skinny-vm-events-v3.txt
Description:Modelled on chan_zap and chan_mgcp.  I have been chasing a segfault
that initially appeared to be related to IMAP and voicemail.  After
looking at way too many core dumps I finally noticed that while the
crash occured in the c-client code, the call trace always pointed
to starting in the do_housekeeping finction in chan_skinny.

The function do_housekeeping calls has_voicemail which in chan_skinny
is just a call to ast_app_has_voicemail.  I reworked the do_housekeeping
and has_voicemail functions to resemble their counterparts in chan_zap
and chan_mgcp.

So far I have not been able to recreate the segfault with light VM
interaction, were as before the patch one call would typically trigger
the dump.

****** ADDITIONAL INFORMATION ******

This patch should also apply to branch 1.6.

Comments:By: Jason Parker (jparker) 2008-03-25 18:38:09

+if (!ast_strlen_zero(mailbox)) {
+ char *mailbox, *context;

That bothers me slightly.  Can you rename the variables that have the same name (I realize scope is fine, but it's a bit confusing if you're trying to follow a variable).

Besides some minor whitespace issues, it looks alright.  Unfortunately, my 7970 is acting stupid (thanks Cisco), so I can't test this..
By: dea (dea) 2008-03-25 19:19:55

Tweaked and uploaded.

Since I applied the this patch and the patch to make app_voicemail honor
the context for event bas mwi I have not had another segfault on my
IMAP enabled system.
By: dea (dea) 2008-03-25 19:31:59

Crud.  I managed to upload a bogus patch.  Please drop/ignore -v2
By: Digium Subversion (svnbot) 2008-04-27 10:12:04

Repository: asterisk
Revision: 114700

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r114700 | mvanbaak | 2008-04-27 10:12:01 -0500 (Sun, 27 Apr 2008) | 8 lines

Make MWI in chan_skinny event based modeled after chan_zap and chan_mgcp.

(closes issue ASTERISK-11642)
Reported by: DEA
Patches:
     chan_skinny-vm-events-v3.txt uploaded by DEA (license 3)
 Tested by: DEA and me

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114700
By: Digium Subversion (svnbot) 2008-04-27 10:15:29

Repository: asterisk
Revision: 114701

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_skinny.c

------------------------------------------------------------------------
r114701 | mvanbaak | 2008-04-27 10:15:28 -0500 (Sun, 27 Apr 2008) | 18 lines

Merged revisions 114700 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

Merged to 1.6 because it fixes a crash.

........
r114700 | mvanbaak | 2008-04-27 17:17:18 +0200 (Sun, 27 Apr 2008) | 8 lines

Make MWI in chan_skinny event based modeled after chan_zap and chan_mgcp.

(closes issue ASTERISK-11642)
Reported by: DEA
Patches:
     chan_skinny-vm-events-v3.txt uploaded by DEA (license 3)
 Tested by: DEA and me

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114701