[Home]

Summary:ASTERISK-11640: The LDAP version is not taken into account
Reporter:Sylvain Desbureaux (sylvain)Labels:
Date Opened:2008-03-14 05:00:50Date Closed:2008-03-18 15:10:32
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_config_ldap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_ldap_version_port.patch
Description:if a version of LDAP protocol is set in general like here:
[_general]
host=linuxsde ; LDAP host(s)
port=10389 ;
protocol=3 ; Version of the LDAP protocol to use default is 3.
basedn=system ; Base DN
pass=secret ; Bind password
user=admin ; Bind DN

it is not taken into account and the protocol version is 2.
After code investigation, it seems that "version" is not read. I give in additionnal Information the patch which make it work for 1.6.0 branch (with previous patch making ldap working with unstandard port)
Comments:By: Sylvain Desbureaux (sylvain) 2008-03-14 05:17:25

made a mistake, here's a new patch:

<patch in bug message deleted, see attachment>


By: snuffy (snuffy) 2008-03-14 06:49:23

sylvain, patches should NEVER be posted in bug report or notes in a bug report.
You should attach the change in code via the 'upload file' section and tick 'code or documentation submission'
This is required for legal reasons from digium's licensing department
By: Sylvain Desbureaux (sylvain) 2008-03-14 07:07:12

/!\ Be aware that the patch provided fix ALSO 0012209 issue /!\
By: Donny Kavanagh (donnyk) 2008-03-14 14:56:46

Sylvain,

Have you gone through the digium license procedure? (submitted your license for approval)
By: Mark Michelson (mmichelson) 2008-03-14 15:17:32

juggie

the license is pending right now. It'll probably be approved Monday or at the latest, Tuesday.
By: Donny Kavanagh (donnyk) 2008-03-14 15:20:39

Ok perfect, i wasnt sure if 'License Pending' on the file ment that it had been submitted by the bug reporter, or if it was Pending in the general sense.
By: Tilghman Lesher (tilghman) 2008-03-16 10:39:57

Waiting for license to be approved.
By: Digium Subversion (svnbot) 2008-03-18 15:09:37

Repository: asterisk
Revision: 109683

U   trunk/res/res_config_ldap.c

------------------------------------------------------------------------
r109683 | tilghman | 2008-03-18 15:09:36 -0500 (Tue, 18 Mar 2008) | 4 lines

Set protocol version, port number correctly.
(closes issue ASTERISK-11640, closes issue ASTERISK-11638)
Reported by: sylvain

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=109683
By: Digium Subversion (svnbot) 2008-03-18 15:10:32

Repository: asterisk
Revision: 109684

_U  branches/1.6.0/
U   branches/1.6.0/res/res_config_ldap.c

------------------------------------------------------------------------
r109684 | tilghman | 2008-03-18 15:10:31 -0500 (Tue, 18 Mar 2008) | 12 lines

Merged revisions 109683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r109683 | tilghman | 2008-03-18 15:13:40 -0500 (Tue, 18 Mar 2008) | 4 lines

Set protocol version, port number correctly.
(closes issue ASTERISK-11640, closes issue ASTERISK-11638)
Reported by: sylvain

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=109684