[Home]

Summary:ASTERISK-11639: Possible crash if chan is null
Reporter:Eric Dantie (edantie)Labels:
Date Opened:2008-03-14 04:00:56Date Closed:2008-03-14 10:19:36
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:in res/res_musiconhold.c, line 211-215
<code>
static void moh_files_release(struct ast_channel *chan, void *data)
{
       struct moh_files_state *state = chan->music_state;

       if (chan && state) {
</code>

can crash if chan is NULL

Comments:By: Digium Subversion (svnbot) 2008-03-14 09:25:02

Repository: asterisk
Revision: 108682

U   branches/1.4/res/res_musiconhold.c

------------------------------------------------------------------------
r108682 | qwell | 2008-03-14 09:24:59 -0500 (Fri, 14 Mar 2008) | 4 lines

Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue ASTERISK-11639, credit to edantie for pointing this out.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=108682
By: Digium Subversion (svnbot) 2008-03-14 09:28:57

Repository: asterisk
Revision: 108683

_U  trunk/
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r108683 | qwell | 2008-03-14 09:28:53 -0500 (Fri, 14 Mar 2008) | 12 lines

Merged revisions 108682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r108682 | qwell | 2008-03-14 09:29:05 -0500 (Fri, 14 Mar 2008) | 4 lines

Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue ASTERISK-11639, credit to edantie for pointing this out.

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=108683
By: Digium Subversion (svnbot) 2008-03-14 09:29:34

Repository: asterisk
Revision: 108684

_U  branches/1.6.0/
U   branches/1.6.0/res/res_musiconhold.c

------------------------------------------------------------------------
r108684 | qwell | 2008-03-14 09:29:29 -0500 (Fri, 14 Mar 2008) | 20 lines

Merged revisions 108683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r108683 | qwell | 2008-03-14 09:32:55 -0500 (Fri, 14 Mar 2008) | 12 lines

Merged revisions 108682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r108682 | qwell | 2008-03-14 09:29:05 -0500 (Fri, 14 Mar 2008) | 4 lines

Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue ASTERISK-11639, credit to edantie for pointing this out.

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=108684
By: Digium Subversion (svnbot) 2008-03-14 10:19:36

Repository: asterisk
Revision: 108709

_U  team/group/ast_storage/
U   team/group/ast_storage/res/res_musiconhold.c

------------------------------------------------------------------------
r108709 | qwell | 2008-03-14 10:19:35 -0500 (Fri, 14 Mar 2008) | 20 lines

Merged revisions 108683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r108683 | qwell | 2008-03-14 09:32:55 -0500 (Fri, 14 Mar 2008) | 12 lines

Merged revisions 108682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r108682 | qwell | 2008-03-14 09:29:05 -0500 (Fri, 14 Mar 2008) | 4 lines

Fix a potential segfault if chan (or chan->music_state) is NULL.

Closes issue ASTERISK-11639, credit to edantie for pointing this out.

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=108709