| Summary: | ASTERISK-11637: [patch] janitor project for getvar_helper in app_queue | ||
| Reporter: | snuffy (snuffy) | Labels: | |
| Date Opened: | 2008-05-28 12:03:00 | Date Closed: | 2008-05-28 14:52:41 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Applications/app_queue |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) bug_12742.diff | |
| Description: | Some fixes to make accessing to returned values for getvar_helper threadsafe. Also noted small improvement to check for mixmonitor application before parsing out extra arguements to mixmonitor as per discussion with putnoput on irc. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-05-28 14:50:15 Repository: asterisk Revision: 118783 U trunk/apps/app_queue.c ------------------------------------------------------------------------ r118783 | mmichelson | 2008-05-28 14:49:57 -0500 (Wed, 28 May 2008) | 15 lines Update to the janitor project for making sure to be thread-safe when retrieving the value of a channel variable. This covers app_queue. This commit also incorporates a logical change. Previously, if MixMonitor is to be used to record the call, all the arguments were parsed first. Then the MixMonitor app would be located. Now the order of these operations has been swapped. Now the app is located first so that we only go through the work of parsing the arguments if the app was found. (closes issue ASTERISK-11637) Reported by: snuffy Patches: bug_12742.diff uploaded by snuffy (license 35) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118783 By: Digium Subversion (svnbot) 2008-05-28 14:52:41 Repository: asterisk Revision: 118784 _U branches/1.6.0/ ------------------------------------------------------------------------ r118784 | mmichelson | 2008-05-28 14:52:24 -0500 (Wed, 28 May 2008) | 22 lines Blocked revisions 118783 via svnmerge ........ r118783 | mmichelson | 2008-05-28 14:56:18 -0500 (Wed, 28 May 2008) | 15 lines Update to the janitor project for making sure to be thread-safe when retrieving the value of a channel variable. This covers app_queue. This commit also incorporates a logical change. Previously, if MixMonitor is to be used to record the call, all the arguments were parsed first. Then the MixMonitor app would be located. Now the order of these operations has been swapped. Now the app is located first so that we only go through the work of parsing the arguments if the app was found. (closes issue ASTERISK-11637) Reported by: snuffy Patches: bug_12742.diff uploaded by snuffy (license 35) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=118784 | ||