Summary:	ASTERISK-11626: [patch] Make Menuselect bombs on a clean checkout or make dist-clean if configure not run.
Reporter:	Donny Kavanagh (donnyk)	Labels:
Date Opened:	2008-03-12 11:55:37	Date Closed:	2008-07-05 10:13:55
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 12197.diff ( 1) makemenuselect.txt
Description:	As stated in subject, run make menuselect before a configure on a clean checkout or a checkout that has just been cleaned with make dist-clean and it will bomb out in a dramatic way.  (see attached file) The end result however is not simply that you run ./configure, and then run make menuselect because if you do that, you will notice that make menu select now has every single option enabled and detected as available within your system.  And of course running make will fail as you likely do not have every single dependency. ****** STEPS TO REPRODUCE ****** 1) Check out a clean copy of trunk, or run make dist-clean on something you have checked out. 2) Run make menuselect 3) Watch it bomb 4) Run configure 5) Run make menuselect again 6) now note that every single option is detected as avail on your system 7) for fun try a make and it will likely die on a missing library.
Comments:	By: Tilghman Lesher (tilghman) 2008-03-12 13:34:49 Okay, and if you look at the second last line, it tells you EXACTLY what you should do.  I'm not sure what else you expect that we should do. By: Donny Kavanagh (donnyk) 2008-03-12 14:28:23 Corydon, you did not read the details. If you do so (run configure) then run make menuselect, then EVERY option is detected as on your system, it thinks you have every lib possible.  So of course your compile will bomb.  The only way to fix it is to run a make dist-clean and then run a configure first as you should. By: Donny Kavanagh (donnyk) 2008-03-12 15:34:30 I've attached a patch to the Makefile which i believe solves the issue of allowing make menuselect to run without ./configure having been run.  I only taught myself makefiles today so be nice, none the less though i think it is correct. By: Digium Subversion (svnbot) 2008-03-14 15:10:01 Repository: asterisk Revision: 108799 U   trunk/Makefile ------------------------------------------------------------------------ r108799 | russell | 2008-03-14 15:09:59 -0500 (Fri, 14 Mar 2008) | 8 lines Make sure configure is run before menuselect on a clean checkout (closes issue ASTERISK-11626) Reported by: juggie Patches:      12197.diff uploaded by juggie (license 24) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=108799 By: Digium Subversion (svnbot) 2008-03-14 15:10:47 Repository: asterisk Revision: 108800 _U  branches/1.6.0/ U   branches/1.6.0/Makefile ------------------------------------------------------------------------ r108800 | russell | 2008-03-14 15:10:45 -0500 (Fri, 14 Mar 2008) | 16 lines Merged revisions 108799 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r108799 | russell | 2008-03-14 15:14:06 -0500 (Fri, 14 Mar 2008) | 8 lines Make sure configure is run before menuselect on a clean checkout (closes issue ASTERISK-11626) Reported by: juggie Patches:      12197.diff uploaded by juggie (license 24) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=108800 By: Donny Kavanagh (donnyk) 2008-03-26 21:19:52 Russell, your fix does not work in my testing, also confirmed by lmadsen.  My patch does work however. By: Digium Subversion (svnbot) 2008-03-31 12:10:19 Repository: asterisk Revision: 111998 U   trunk/Makefile ------------------------------------------------------------------------ r111998 | russell | 2008-03-31 12:10:16 -0500 (Mon, 31 Mar 2008) | 7 lines Ensure configure gets run on a clean checkout. (closes issue ASTERISK-11626) Reported by: juggie Patches:      12197.diff uploaded by juggie (license 24) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=111998 By: Digium Subversion (svnbot) 2008-03-31 12:10:39 Repository: asterisk Revision: 111999 _U  branches/1.6.0/ U   branches/1.6.0/Makefile ------------------------------------------------------------------------ r111999 | russell | 2008-03-31 12:10:38 -0500 (Mon, 31 Mar 2008) | 15 lines Merged revisions 111998 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r111998 | russell | 2008-03-31 12:14:58 -0500 (Mon, 31 Mar 2008) | 7 lines Ensure configure gets run on a clean checkout. (closes issue ASTERISK-11626) Reported by: juggie Patches:      12197.diff uploaded by juggie (license 24) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=111999