[Home]

Summary:ASTERISK-11464: Incorrect description of echo can status
Reporter:jeffery palmer (darren1713)Labels:
Date Opened:2008-02-18 11:52:30.000-0600Date Closed:2008-02-18 15:27:03.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The status of echocancelwhenbridged is backwards when executing "zap show channel #". This is a problem in SVN, and branch 1.4.


****** ADDITIONAL INFORMATION ******

currently:
  tmp->echocanbridged ? "" : "(unless TDM bridged) "
should be:
  tmp->echocanbridged ? "(unless TDM bridged) " : ""


chan_zap.c line ASTERISK-11317
        ast_cli(a->fd, "\t%scurrently %s\n", tmp->echocanbridged ? "" : "(unless TDM bridged) ", tmp->echocanon ? "ON" : "OFF");
Comments:By: Jason Parker (jparker) 2008-02-18 12:00:32.000-0600

I think your assessment is incorrect.

If we have echo cancellation when bridged (ie: tmp->echocanbridged == 1), we always have %d taps.

If we do NOT have echo cancellation when bridged, we have %d taps (unless TDM bridged)


Am I reading the code wrong?
By: jeffery palmer (darren1713) 2008-02-18 13:37:48.000-0600

I now understand after reviewing it all that when echocancel=yes the messages make sense, but when echocancel=no, as you can see below, it makes no sense.

echocancel=no
echocancelwhenbridged=yes
prints message
"Echo Cancellation: 0 taps, currently OFF"

echocancel=no
echocancelwhenbridged=no
prints message
"Echo Cancellation: 0 taps unless TDM bridged, currently OFF"

This brings up a point that I don't know the answer to. If echocancel=no, does echocancelwhenbridged=yes still work on bridged channels? If not, then "unless TDM bridged" should not be printed when echocancel=no.
By: Jason Parker (jparker) 2008-02-18 14:18:51.000-0600

echocancelwhenbridged does not work if echocancel is off.

So, (!tmp->echocancel || tmp->echocanbridged) ? "" : "unless TDM bridged" maybe?
By: jeffery palmer (darren1713) 2008-02-18 15:13:29.000-0600

That would correct the message. Looks good to me.
By: Digium Subversion (svnbot) 2008-02-18 15:20:09.000-0600

Repository: asterisk
Revision: 103790

U   branches/1.4/channels/chan_zap.c

------------------------------------------------------------------------
r103790 | qwell | 2008-02-18 15:20:07 -0600 (Mon, 18 Feb 2008) | 4 lines

Correct a message when echocancelwhenbridged is on, but echocancel is not.

Issue ASTERISK-11464

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103790
By: Digium Subversion (svnbot) 2008-02-18 15:27:00.000-0600

Repository: asterisk
Revision: 103791

_U  trunk/
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r103791 | qwell | 2008-02-18 15:26:58 -0600 (Mon, 18 Feb 2008) | 12 lines

Merged revisions 103790 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103790 | qwell | 2008-02-18 15:23:32 -0600 (Mon, 18 Feb 2008) | 4 lines

Correct a message when echocancelwhenbridged is on, but echocancel is not.

Closes issue ASTERISK-11464

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103791