| Summary: | ASTERISK-11446: [patch] invalid strcpy for conf2ael | ||
| Reporter: | Clod Patry (junky) | Labels: | |
| Date Opened: | 2008-02-15 03:14:00.000-0600 | Date Closed: | 2008-02-15 16:33:47.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Utilities/aelparse |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) conf2ael.diff | |
| Description: | Probably due to a change from //extern char ast_config_AST_CONFIG_DIR[PATH_MAX]; to const char *ast_config_AST_CONFIG_DIR = "/etc/asterisk"; /* placeholder */ that line was causing a segfault, when running: root@rabbit:/usr/src/asterisk-trunk# conf2ael WARNING: This is an EXTREMELY preliminary version of a program that will someday hopefully do a thoughful and intelligent job of transforming your extensions.conf file into an extensions.ael file. This version has absolutely no intelligence, and pretty much just does a direct conversion The result will most likely need careful attention to finish the job!!!!! (You could use -d the use the extensions.conf in the current directory!) Segmentation fault (core dumped) root@rabbit:/usr/src/asterisk-trunk# | ||
| Comments: | By: Clod Patry (junky) 2008-02-15 08:01:09.000-0600 will be better with the patch. By: Digium Subversion (svnbot) 2008-02-15 09:42:15.000-0600 Repository: asterisk Revision: 103716 U trunk/utils/conf2ael.c ------------------------------------------------------------------------ r103716 | tilghman | 2008-02-15 09:42:13 -0600 (Fri, 15 Feb 2008) | 6 lines Remove extraneous copy (closes issue ASTERISK-11446) Reported by: junky Patches: conf2ael.diff uploaded by junky (license 177) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=103716 By: Digium Subversion (svnbot) 2008-02-15 16:33:47.000-0600 Repository: asterisk Revision: 103735 _U team/murf/bug11210/ U team/murf/bug11210/apps/app_queue.c U team/murf/bug11210/channels/chan_sip.c U team/murf/bug11210/channels/chan_zap.c U team/murf/bug11210/channels/misdn/chan_misdn_config.h U team/murf/bug11210/channels/misdn/ie.c U team/murf/bug11210/channels/misdn/isdn_lib.c U team/murf/bug11210/channels/misdn/isdn_lib.h U team/murf/bug11210/channels/misdn/isdn_msg_parser.c U team/murf/bug11210/channels/misdn/portinfo.c U team/murf/bug11210/configure U team/murf/bug11210/configure.ac U team/murf/bug11210/doc/tex/imapstorage.tex U team/murf/bug11210/include/asterisk/extconf.h U team/murf/bug11210/include/asterisk/strings.h U team/murf/bug11210/include/asterisk/time.h U team/murf/bug11210/main/ast_expr2f.c U team/murf/bug11210/main/channel.c U team/murf/bug11210/main/config.c U team/murf/bug11210/main/loader.c U team/murf/bug11210/res/res_config_curl.c U team/murf/bug11210/res/res_config_ldap.c U team/murf/bug11210/res/res_phoneprov.c U team/murf/bug11210/utils/conf2ael.c ------------------------------------------------------------------------ r103735 | murf | 2008-02-15 16:33:45 -0600 (Fri, 15 Feb 2008) | 120 lines Merged revisions 103710-103711,103714-103716,103723,103725,103727,103729 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r103710 | mmichelson | 2008-02-14 17:53:08 -0700 (Thu, 14 Feb 2008) | 13 lines Blocked revisions 103709 via svnmerge ........ r103709 | mmichelson | 2008-02-14 18:50:49 -0600 (Thu, 14 Feb 2008) | 6 lines I apparently misunderstood one of the requirements of this configure change. Now, if a source directory is specified with the --with-imap option, and a valid source installation is not detected there, then configure will fail and will not check for a package installation. ........ ................ r103711 | mmichelson | 2008-02-14 17:59:21 -0700 (Thu, 14 Feb 2008) | 3 lines Same changes as made to 1.4 in revision 103710 ................ r103714 | mmichelson | 2008-02-15 08:08:59 -0700 (Fri, 15 Feb 2008) | 15 lines Blocked revisions 103713 via svnmerge ........ r103713 | mmichelson | 2008-02-15 09:05:49 -0600 (Fri, 15 Feb 2008) | 8 lines Fix a bit of wrong logic in the configure script that caused problems when trying to configure without IMAP. Patch suggestion from phsultan, but I modified it slightly. (closes issue ASTERISK-11447) Reported by: pj Tested by: putnopvut ........ ................ r103715 | mmichelson | 2008-02-15 08:11:23 -0700 (Fri, 15 Feb 2008) | 3 lines Merging of changes from 1.4 revision 103713. ................ r103716 | tilghman | 2008-02-15 08:45:33 -0700 (Fri, 15 Feb 2008) | 6 lines Remove extraneous copy (closes issue ASTERISK-11446) Reported by: junky Patches: conf2ael.diff uploaded by junky (license 177) ................ r103723 | qwell | 2008-02-15 10:29:08 -0700 (Fri, 15 Feb 2008) | 6 lines Fix up some doxygen issues. (closes issue ASTERISK-11440) Patches: bug_11996_doxygen.diff uploaded by snuffy (license 35) ................ r103725 | mmichelson | 2008-02-15 10:32:43 -0700 (Fri, 15 Feb 2008) | 16 lines Merged revisions 103722 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r103722 | mmichelson | 2008-02-15 11:26:37 -0600 (Fri, 15 Feb 2008) | 8 lines Final round of changes for configure script logic for IMAP Now if a directory is specified, then we will search that directory for a source installation of the IMAP toolkit. If none is found, then we will use that directory as the basis for detecting a package installation of the IMAP c-client. If that check fails, then configure will fail. ........ ................ r103727 | russell | 2008-02-15 11:34:42 -0700 (Fri, 15 Feb 2008) | 14 lines Merged revisions 103726 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r103726 | russell | 2008-02-15 12:33:29 -0600 (Fri, 15 Feb 2008) | 6 lines Don't attempt to execute the reload callback for a module that returned AST_MODULE_LOAD_DECLINE. This fixes a crash that was reported against chan_console in trunk. (closes issue ASTERISK-11401, reported by junky, fixed by me) ........ ................ r103729 | russell | 2008-02-15 12:50:47 -0700 (Fri, 15 Feb 2008) | 12 lines Merged revisions 103728 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r103728 | russell | 2008-02-15 13:50:11 -0600 (Fri, 15 Feb 2008) | 4 lines In the case that you try to directly reload a module has returned AST_MODULE_LOAD_DECLINE, log a message indicating that the module is not fully initialized and must be initialized using "module load". ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=103735 | ||