[Home]

Summary:ASTERISK-11433: [patch] possible memory leak while allocating PRI channels
Reporter:Tilghman Lesher (tilghman)Labels:
Date Opened:2008-02-13 19:27:42.000-0600Date Closed:2008-06-12 13:36:09
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080213__zap_memleak.diff.txt
Description:While investigating another issue, I found what appears to be a memory leak and bad behavior, when a particular allocation in chan_zap fails.
Comments:By: Mark Spencer (markster) 2008-02-14 08:21:20.000-0600

To clarify were you actually having a problem with pri_sr_new() returning NULL or just noticed that this was a leak?

Mark
By: Tilghman Lesher (tilghman) 2008-02-14 08:59:03.000-0600

I just noticed that it appeared to be a leak, but I need someone who is more familiar with that code to confirm.
By: Jason Parker (jparker) 2008-05-01 16:12:56

What might make things easier here, would be to move the pri_sr_new() call to before pri_new_call(), and then just add the return -1.

Thoughts?
By: Jason Parker (jparker) 2008-05-01 16:17:01

oh..but then you would have to free sr.  pri_sr_free() it then, I guess.
By: Digium Subversion (svnbot) 2008-06-04 13:29:24

Repository: asterisk
Revision: 120425

U   branches/1.4/channels/chan_zap.c

------------------------------------------------------------------------
r120425 | tilghman | 2008-06-04 13:29:20 -0500 (Wed, 04 Jun 2008) | 6 lines

If we fail to setup the PRI request channel, don't continue, exit with an error.
(closes issue ASTERISK-11433)
Reported by: Corydon76
Patches:
      20080213__zap_memleak.diff.txt uploaded by Corydon76 (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=120425
By: Digium Subversion (svnbot) 2008-06-04 13:30:43

Repository: asterisk
Revision: 120426

_U  trunk/
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r120426 | tilghman | 2008-06-04 13:30:41 -0500 (Wed, 04 Jun 2008) | 14 lines

Merged revisions 120425 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r120425 | tilghman | 2008-06-04 13:35:47 -0500 (Wed, 04 Jun 2008) | 6 lines

If we fail to setup the PRI request channel, don't continue, exit with an error.
(closes issue ASTERISK-11433)
Reported by: Corydon76
Patches:
      20080213__zap_memleak.diff.txt uploaded by Corydon76 (license 14)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=120426
By: Digium Subversion (svnbot) 2008-06-12 13:36:09

Repository: asterisk
Revision: 122310

U   team/jpeeler/chan_dahdi14/channels/chan_dahdi.c

------------------------------------------------------------------------
r122310 | jpeeler | 2008-06-12 13:36:08 -0500 (Thu, 12 Jun 2008) | 7 lines

If we fail to setup the PRI request channel, don't continue, exit with an error.
(closes issue ASTERISK-11433)
Reported by: Corydon76
Patches:
      20080213__zap_memleak.diff.txt uploaded by Corydon76 (license 14)
(Moved from chan_zap to chan_dahdi)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=122310