| Summary: | ASTERISK-11414: [patch] Changes to configuration files to make setting up virtual hosting more obvious | ||
| Reporter: | Philip Prindeville (pprindeville) | Labels: | |
| Date Opened: | 2008-02-10 19:52:03.000-0600 | Date Closed: | 2008-03-25 13:07:23 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/NewFeature |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) acme-virtualpbx.1.6.patch ( 1) bugid-0011969.1.6.patch ( 2) virtualhost-rev3.diff.txt | |
| Description: | Setting up virtual hosting is an issue that often comes up on the asterisk-users mailing list. Having read this list for several months, I decided to combine the work that we had done at our site with some of the more frequent questions and rework the sample configurations (macros included) to be clearer. This was done removing the default (or implicitly default) context from extensions and voicemail configurations. ****** ADDITIONAL INFORMATION ****** Minor compatibility issues will be present with stdPrivacyexten, as a new argument was added and it was inserted before two existing arguments. The existing examples using stdexten were changed to specify the next action if the caller bails from voicemail. And an example of a virtual hosted company called "acme" was added to two configuration files. | ||
| Comments: | By: Philip Prindeville (pprindeville) 2008-02-10 21:42:01.000-0600 Ignore the first patch. It was using a locally modified version of the expression grammar that isn't portable. By: Philip Prindeville (pprindeville) 2008-02-11 00:57:16.000-0600 Modified the original syntax to use the ? :: operator to simplify a bit. So ignore the second patch as well. By: Tilghman Lesher (tilghman) 2008-02-27 14:16:56.000-0600 In some of these changes, you are inserting an argument in the middle of the argument list, instead of at the end. I'd prefer that: 1) you add arguments only to the end. 2) you use Gosub, instead of Macro, since Macro is now deprecated. By: Philip Prindeville (pprindeville) 2008-03-10 19:02:20 Can we fix this in 1.4, and merge it to 1.6 later? By: Michiel van Baak (mvanbaak) 2008-03-10 19:19:03 I would suggest you create a diff against current trunk and ask for it to be in the next 1.6 1.4 is feature frozen and this does not fix a bug so it should not go into 1.4 By: Philip Prindeville (pprindeville) 2008-03-23 01:09:02 As per mvanbaak's note, I've created diffs for 1.6. Not clear about the use of commas in 1.6. There's not an abundance of examples of the use of Gosub() in 1.6. The examples I looked at were all ael-test... By: Philip Prindeville (pprindeville) 2008-03-23 14:03:17 Afterthought: should the return value have been ${DIALSTATUS}? By: Philip Prindeville (pprindeville) 2008-03-24 21:22:49 Broke this out into two different issues. 12293: update stdexten/stdPrivacyexten in extensions.conf to use Gosub, while adding an optional voicemail context parameter. 11969: update the extensions.conf and voicemail.conf samples to include a voicemail context for virtual hosting. 12293 will need to be committed before 11969. By: Digium Subversion (svnbot) 2008-03-25 12:42:16 Repository: asterisk Revision: 110691 U trunk/configs/extensions.conf.sample U trunk/configs/voicemail.conf.sample ------------------------------------------------------------------------ r110691 | tilghman | 2008-03-25 12:42:15 -0500 (Tue, 25 Mar 2008) | 6 lines Update sample configurations to make virtual hosting more obvious. (closes issue ASTERISK-11414) Reported by: pprindeville Patches: acme-virtualpbx.1.6.patch uploaded by pprindeville (license 347) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=110691 By: Digium Subversion (svnbot) 2008-03-25 12:43:09 Repository: asterisk Revision: 110692 _U branches/1.6.0/ U branches/1.6.0/configs/extensions.conf.sample U branches/1.6.0/configs/voicemail.conf.sample ------------------------------------------------------------------------ r110692 | tilghman | 2008-03-25 12:43:09 -0500 (Tue, 25 Mar 2008) | 14 lines Merged revisions 110691 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r110691 | tilghman | 2008-03-25 12:46:34 -0500 (Tue, 25 Mar 2008) | 6 lines Update sample configurations to make virtual hosting more obvious. (closes issue ASTERISK-11414) Reported by: pprindeville Patches: acme-virtualpbx.1.6.patch uploaded by pprindeville (license 347) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=110692 By: Digium Subversion (svnbot) 2008-03-25 12:59:05 Repository: asterisk Revision: 110693 _U team/group/cdr_backend_ast_str/ U team/group/cdr_backend_ast_str/CHANGES U team/group/cdr_backend_ast_str/Makefile U team/group/cdr_backend_ast_str/channels/chan_iax2.c U team/group/cdr_backend_ast_str/channels/chan_sip.c U team/group/cdr_backend_ast_str/configs/extensions.conf.sample U team/group/cdr_backend_ast_str/configs/sip.conf.sample U team/group/cdr_backend_ast_str/configs/voicemail.conf.sample U team/group/cdr_backend_ast_str/include/asterisk/options.h U team/group/cdr_backend_ast_str/main/app.c U team/group/cdr_backend_ast_str/main/asterisk.c U team/group/cdr_backend_ast_str/main/channel.c ------------------------------------------------------------------------ r110693 | tilghman | 2008-03-25 12:58:50 -0500 (Tue, 25 Mar 2008) | 140 lines Merged revisions 110610,110615,110619,110621,110625,110629,110631,110636,110639,110689,110691 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r110610 | file | 2008-03-24 10:28:25 -0500 (Mon, 24 Mar 2008) | 6 lines Only print out the set_address_from_contact host verbose message if debugging is enabled on the dialog. (closes issue ASTERISK-11703) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110615 | russell | 2008-03-24 12:36:04 -0500 (Mon, 24 Mar 2008) | 10 lines Merged revisions 110614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110614 | russell | 2008-03-24 12:34:56 -0500 (Mon, 24 Mar 2008) | 2 lines Turn a NOTICE into a DEBUG message. ........ ................ r110619 | mmichelson | 2008-03-24 14:19:37 -0500 (Mon, 24 Mar 2008) | 23 lines Merged revisions 110618 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110618 | mmichelson | 2008-03-24 14:17:41 -0500 (Mon, 24 Mar 2008) | 15 lines This is a revert for revision 108288. The reason is that that revision was not for an actual bug fix per se, and so it really should not have been in 1.4 in the first place. Plus, people who compile with DO_CRASH are more likely to encounter a crash due to this change. While I think the usage of DO_CRASH in ast_sched_del is a bit absurd, this sort of change is beyond the scope of 1.4 and should be done instead in a developer branch based on trunk so that all scheduler functions are fixed at once. I also am reverting the change to trunk and 1.6 since they also suffer from the DO_CRASH potential. (closes issue ASTERISK-11695) Reported by: qq12345 ........ ................ r110621 | mmichelson | 2008-03-24 15:14:07 -0500 (Mon, 24 Mar 2008) | 11 lines Remove the "Event: registration" header from Asterisk-generated SIP REGISTER requests. rjain points out that RFC 3265 specifies that the Event: header is not a valid header for REGISTER requests and that the "registration" value is not defined at IANA. (closes issue ASTERISK-11702) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110625 | oej | 2008-03-25 05:54:07 -0500 (Tue, 25 Mar 2008) | 6 lines Use the "Server" header when responding to SIP requests. (closes issue ASTERISK-11701) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110629 | file | 2008-03-25 09:39:45 -0500 (Tue, 25 Mar 2008) | 12 lines Merged revisions 110628 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110628 | file | 2008-03-25 11:37:35 -0300 (Tue, 25 Mar 2008) | 4 lines Add an option (transmit_silence) which transmits silence during both Record() and DTMF generation. The reason this is an option is that in order to transmit silence we have to setup a translation path. This may not be needed/wanted in all cases. (closes issue ASTERISK-9755) Reported by: tracinet ........ ................ r110631 | file | 2008-03-25 10:18:41 -0500 (Tue, 25 Mar 2008) | 4 lines Add a special dialplan variable to chan_sip which will cause an audio file to be played upon completion of an attended transfer. (closes issue ASTERISK-8972) Reported by: sunder ................ r110636 | mmichelson | 2008-03-25 10:41:33 -0500 (Tue, 25 Mar 2008) | 15 lines Merged revisions 110635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110635 | mmichelson | 2008-03-25 10:40:33 -0500 (Tue, 25 Mar 2008) | 7 lines When reverting a commit, I accidentally left in this bit which was an experiment to see what would happen. It passed the compile test, and I didn't notice I had left this change in too. So this is a revert of a revert...sort of. ........ ................ r110639 | mmichelson | 2008-03-25 10:44:01 -0500 (Tue, 25 Mar 2008) | 3 lines Oops here too. I need to stop coding for a while... ................ r110689 | tilghman | 2008-03-25 12:40:28 -0500 (Tue, 25 Mar 2008) | 6 lines Update the sample configuration, to use Macro less (since it's now deprecated). (closes issue ASTERISK-11716) Reported by: pprindeville Patches: bugid-0012293.1.6.patch uploaded by pprindeville (license 347) ................ r110691 | tilghman | 2008-03-25 12:46:34 -0500 (Tue, 25 Mar 2008) | 6 lines Update sample configurations to make virtual hosting more obvious. (closes issue ASTERISK-11414) Reported by: pprindeville Patches: acme-virtualpbx.1.6.patch uploaded by pprindeville (license 347) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=110693 By: Digium Subversion (svnbot) 2008-03-25 13:07:23 Repository: asterisk Revision: 110694 _U team/murf/bug11210/ U team/murf/bug11210/CHANGES U team/murf/bug11210/Makefile U team/murf/bug11210/channels/chan_iax2.c U team/murf/bug11210/channels/chan_sip.c U team/murf/bug11210/configs/extensions.conf.sample U team/murf/bug11210/configs/sip.conf.sample U team/murf/bug11210/configs/voicemail.conf.sample U team/murf/bug11210/include/asterisk/options.h U team/murf/bug11210/main/app.c U team/murf/bug11210/main/asterisk.c U team/murf/bug11210/main/channel.c ------------------------------------------------------------------------ r110694 | murf | 2008-03-25 13:07:18 -0500 (Tue, 25 Mar 2008) | 140 lines Merged revisions 110610,110615,110619,110621,110625,110629,110631,110636,110639,110689,110691 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r110610 | file | 2008-03-24 09:28:25 -0600 (Mon, 24 Mar 2008) | 6 lines Only print out the set_address_from_contact host verbose message if debugging is enabled on the dialog. (closes issue ASTERISK-11703) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110615 | russell | 2008-03-24 11:36:04 -0600 (Mon, 24 Mar 2008) | 10 lines Merged revisions 110614 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110614 | russell | 2008-03-24 12:34:56 -0500 (Mon, 24 Mar 2008) | 2 lines Turn a NOTICE into a DEBUG message. ........ ................ r110619 | mmichelson | 2008-03-24 13:19:37 -0600 (Mon, 24 Mar 2008) | 23 lines Merged revisions 110618 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110618 | mmichelson | 2008-03-24 14:17:41 -0500 (Mon, 24 Mar 2008) | 15 lines This is a revert for revision 108288. The reason is that that revision was not for an actual bug fix per se, and so it really should not have been in 1.4 in the first place. Plus, people who compile with DO_CRASH are more likely to encounter a crash due to this change. While I think the usage of DO_CRASH in ast_sched_del is a bit absurd, this sort of change is beyond the scope of 1.4 and should be done instead in a developer branch based on trunk so that all scheduler functions are fixed at once. I also am reverting the change to trunk and 1.6 since they also suffer from the DO_CRASH potential. (closes issue ASTERISK-11695) Reported by: qq12345 ........ ................ r110621 | mmichelson | 2008-03-24 14:14:07 -0600 (Mon, 24 Mar 2008) | 11 lines Remove the "Event: registration" header from Asterisk-generated SIP REGISTER requests. rjain points out that RFC 3265 specifies that the Event: header is not a valid header for REGISTER requests and that the "registration" value is not defined at IANA. (closes issue ASTERISK-11702) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110625 | oej | 2008-03-25 04:54:07 -0600 (Tue, 25 Mar 2008) | 6 lines Use the "Server" header when responding to SIP requests. (closes issue ASTERISK-11701) Reported by: rjain Patches: chan_sip.c.diff uploaded by rjain (license 226) ................ r110629 | file | 2008-03-25 08:39:45 -0600 (Tue, 25 Mar 2008) | 12 lines Merged revisions 110628 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110628 | file | 2008-03-25 11:37:35 -0300 (Tue, 25 Mar 2008) | 4 lines Add an option (transmit_silence) which transmits silence during both Record() and DTMF generation. The reason this is an option is that in order to transmit silence we have to setup a translation path. This may not be needed/wanted in all cases. (closes issue ASTERISK-9755) Reported by: tracinet ........ ................ r110631 | file | 2008-03-25 09:18:41 -0600 (Tue, 25 Mar 2008) | 4 lines Add a special dialplan variable to chan_sip which will cause an audio file to be played upon completion of an attended transfer. (closes issue ASTERISK-8972) Reported by: sunder ................ r110636 | mmichelson | 2008-03-25 09:41:33 -0600 (Tue, 25 Mar 2008) | 15 lines Merged revisions 110635 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r110635 | mmichelson | 2008-03-25 10:40:33 -0500 (Tue, 25 Mar 2008) | 7 lines When reverting a commit, I accidentally left in this bit which was an experiment to see what would happen. It passed the compile test, and I didn't notice I had left this change in too. So this is a revert of a revert...sort of. ........ ................ r110639 | mmichelson | 2008-03-25 09:44:01 -0600 (Tue, 25 Mar 2008) | 3 lines Oops here too. I need to stop coding for a while... ................ r110689 | tilghman | 2008-03-25 11:40:28 -0600 (Tue, 25 Mar 2008) | 6 lines Update the sample configuration, to use Macro less (since it's now deprecated). (closes issue ASTERISK-11716) Reported by: pprindeville Patches: bugid-0012293.1.6.patch uploaded by pprindeville (license 347) ................ r110691 | tilghman | 2008-03-25 11:46:34 -0600 (Tue, 25 Mar 2008) | 6 lines Update sample configurations to make virtual hosting more obvious. (closes issue ASTERISK-11414) Reported by: pprindeville Patches: acme-virtualpbx.1.6.patch uploaded by pprindeville (license 347) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=110694 | ||