[Home]

Summary:ASTERISK-11403: Fast RFC2833 dialing results in asterisk generating overlapping
Reporter:Torrey Searle (tsearle)Labels:
Date Opened:2008-02-08 02:51:08.000-0600Date Closed:2008-02-18 17:55:11.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/Channels
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) fast_dtmf_issue.patch
Description:Scenario: call established between 2 rfc2833 endpoints but no packet 2 packet bridge.

If the calling party sends digits really fast (less than the min gap of 45 milliseconds).  Asterisk will attempt to slow down the dialing through dtmf emulation.  

When this occurs, it is possible that the next digit arrives while the previous digit is still being emulated by asterisk.  Currently asterisk doesn't check to see if a dtmf is currently being emulating before forwarding the start frame of the next dtmf.

This patch adds a check so that if the previous digit is still being played the start frame will not be forwarded (the end frame will be enqueued for emulation).



****** ADDITIONAL INFORMATION ******

This issue seems to be the same as one briefly mentioned in 11740  
http://bugs.digium.com/view.php?id=11740#81781

As 11740 seems to cover several seemingly un-related dtmf issues (it's moved on to a sip-info problem), I'm separating this issue out for clarity
Comments:By: Dmitry Andrianov (dimas) 2008-02-08 07:36:02.000-0600

Not only 11740 "briefly mentioned" this behavior but it also has the patch attached - v1-11740.patch. People also say there that patch fixed other issues for them so I'm a bit unclear why you isolated it under separaet issue losing the history etc...
By: Torrey Searle (tsearle) 2008-02-11 09:07:49.000-0600

I'm sorry I don't want to step on anybody else's feet.  The patch in 11740 does indeed propose the same solution.  However, 11740 contains many other issues, not directly related to this issue.  I'm separating this issue so as it is not blocked by the other issues the ticket is trying to address.
By: Digium Subversion (svnbot) 2008-02-18 17:53:35.000-0600

Repository: asterisk
Revision: 103801

U   branches/1.4/main/channel.c

------------------------------------------------------------------------
r103801 | file | 2008-02-18 17:53:22 -0600 (Mon, 18 Feb 2008) | 10 lines

Ensure that emulated DTMFs do not get interrupted by another begin frame.
(closes issue ASTERISK-11209)
Reported by: gserra
Patches:
     v1-11740.patch uploaded by dimas (license 88)
(closes issue ASTERISK-11403)
Reported by: tsearle
(closes issue ASTERISK-10143)
Reported by: xmarksthespot

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103801
By: Digium Subversion (svnbot) 2008-02-18 17:55:11.000-0600

Repository: asterisk
Revision: 103802

_U  trunk/
U   trunk/main/channel.c

------------------------------------------------------------------------
r103802 | file | 2008-02-18 17:55:10 -0600 (Mon, 18 Feb 2008) | 18 lines

Merged revisions 103801 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r103801 | file | 2008-02-18 19:56:48 -0400 (Mon, 18 Feb 2008) | 10 lines

Ensure that emulated DTMFs do not get interrupted by another begin frame.
(closes issue ASTERISK-11209)
Reported by: gserra
Patches:
     v1-11740.patch uploaded by dimas (license 88)
(closes issue ASTERISK-11403)
Reported by: tsearle
(closes issue ASTERISK-10143)
Reported by: xmarksthespot

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103802