[Home]

Summary:ASTERISK-11388: AelParse dump separates command parameters with pipes, that are not accepted by 1.6
Reporter:Atis Lezdins (atis)Labels:
Date Opened:2008-02-06 05:10:06.000-0600Date Closed:2011-06-07 14:07:23
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Utilities/aelparse
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Processing the following command by aelparse
GoSub(db_dnis_routing,${EXTEN},1);

gives the following .conf file:

GoSub(db_dnis_routing|${EXTEN}|1)

This is valid for 1.4 (but obsolete) however this doesn't work on 1.6

It would be good idea to have aelparse separate command parameters by commas also in 1.4 for compatibility.

Comments:By: Michiel van Baak (mvanbaak) 2008-02-06 12:30:22.000-0600

aelparse in trunk makes this:
GoSub(db_dnis_routing\,${EXTEN}\,1)

By: Atis Lezdins (atis) 2008-02-07 03:58:56.000-0600

My mistake. This is correct in trunk.

What about 1.4 - it would still be good to create dump with commas.

By: Steve Murphy (murf) 2008-02-11 15:52:26.000-0600

I reviewed the code that generates the dump, and it looks OK;

If you have a problem in 1.4, please, supply me a short test AEL input that
I can use, that would demonstrate a problem. Right now, if the output from aelparse is acceptable to the extensions.conf parser, I would hesitate to make even a cosmetic change... Maxims like these ring in my ears: "If it works, don't fix it", and "Thou shalt not change release code, except for really obvious, bad bugs that really need to be fixed."

By: Atis Lezdins (atis) 2008-02-11 18:03:21.000-0600

Ok, then - close the issue.

Probably i deserve some negative karma :(

By: Steve Murphy (murf) 2008-02-12 09:24:02.000-0600

Sorry, no negative karma today. There's a rule against throwing stones in glass houses!