[Home]

Summary:ASTERISK-11386: [patch] change cdr_odbc to use SQLExecDirect() instead of SQLPrepare() then SQLExecute().
Reporter:Private Name (falves11)Labels:
Date Opened:2008-02-05 21:20:11.000-0600Date Closed:2008-03-11 16:07:33
Priority:MajorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_odbc
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080208__bug11935.diff.txt
Description:We already fixed func_odbc to use SQLExecDirect(). It follows that in a very intense operation like mine, I can not use cdr_odbc with its three network calls pero insertion. We need to take the patch already in production for func_odbc and apply the same idea to cdr_odbc.
Comments:By: Private Name (falves11) 2008-02-05 21:21:55.000-0600

The origina case that was already merged and makes func_odbc use SQLExecDirect is 10723

By: Brandon Kruse (bkruse) 2008-02-08 16:34:39.000-0600

Where was the committed? (if it already exists)

-bk

By: Private Name (falves11) 2008-02-08 17:43:37.000-0600

Yes, func_odbc is already working with SQLExecDirect perfectly in the current trunk version. Please check bug id 10723.

By: Tilghman Lesher (tilghman) 2008-02-12 18:16:47.000-0600

I need feedback on this patch.

By: Private Name (falves11) 2008-02-13 03:15:40.000-0600

works as expected. Please merge it.

By: Jason Parker (jparker) 2008-03-11 14:54:49

Corydon: This looks alright.  Any reason not to commit?

By: Tilghman Lesher (tilghman) 2008-03-11 16:02:31

No, just haven't gotten around to it yet.

By: Digium Subversion (svnbot) 2008-03-11 16:06:53

Repository: asterisk
Revision: 107722

U   trunk/cdr/cdr_odbc.c

------------------------------------------------------------------------
r107722 | tilghman | 2008-03-11 16:06:51 -0500 (Tue, 11 Mar 2008) | 7 lines

Convert prepare_and_execute to direct_execute for speed
(closes issue ASTERISK-11386)
Reported by: falves11
Patches:
      20080208__bug11935.diff.txt uploaded by Corydon76 (license 14)
Tested by: falves11, Corydon76

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=107722

By: Digium Subversion (svnbot) 2008-03-11 16:07:33

Repository: asterisk
Revision: 107723

_U  branches/1.6.0/

------------------------------------------------------------------------
r107723 | tilghman | 2008-03-11 16:07:32 -0500 (Tue, 11 Mar 2008) | 14 lines

Blocked revisions 107722 via svnmerge

........
r107722 | tilghman | 2008-03-11 16:10:45 -0500 (Tue, 11 Mar 2008) | 7 lines

Convert prepare_and_execute to direct_execute for speed
(closes issue ASTERISK-11386)
Reported by: falves11
Patches:
      20080208__bug11935.diff.txt uploaded by Corydon76 (license 14)
Tested by: falves11, Corydon76

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=107723