[Home]

Summary:ASTERISK-11385: [patch] replace option_verbose ast_verbose calls with ast_verb
Reporter:Michiel van Baak (mvanbaak)Labels:
Date Opened:2008-02-05 16:00:22.000-0600Date Closed:2008-02-05 16:57:54.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20080205_astverb.diff.txt
( 1) 20080205_astverb-1.diff.txt
( 2) 20080205_astverb-2.diff.txt
Description:There are some places left in the code where option_verbose checks with ast_verbose calls are used. This patch replaces them with ast_verb(level, calls like the janitor project from some time ago.
Comments:By: Mark Michelson (mmichelson) 2008-02-05 16:07:33.000-0600

A lot of these are actually are one off from what they should be. You changed a lot of instances of

ast_verbose(...something...)
to
ast_verb(1,...something...)

which means that it now requires an extra level of verbosity to be printed. If uniformity is what is desired, you can change these to

ast_verb(0,...something...)
By: Michiel van Baak (mvanbaak) 2008-02-05 16:27:58.000-0600

There you go.
By: Mark Michelson (mmichelson) 2008-02-05 16:50:39.000-0600

After discussing the res_agi stuff with you on IRC, I think this patch is a go!
By: Michiel van Baak (mvanbaak) 2008-02-05 16:52:23.000-0600

new patch with res_agi changes we discussed on irc
By: Digium Subversion (svnbot) 2008-02-05 16:57:54.000-0600

Repository: asterisk
Revision: 102525

U   trunk/apps/app_alarmreceiver.c
U   trunk/apps/app_dial.c
U   trunk/apps/app_dumpchan.c
U   trunk/apps/app_followme.c
U   trunk/apps/app_minivm.c
U   trunk/apps/app_privacy.c
U   trunk/apps/app_zapras.c
U   trunk/channels/chan_unistim.c
U   trunk/channels/chan_usbradio.c
U   trunk/main/astmm.c
U   trunk/main/loader.c
U   trunk/main/logger.c
U   trunk/main/pbx.c
U   trunk/main/tcptls.c
U   trunk/res/res_agi.c
U   trunk/res/res_jabber.c

------------------------------------------------------------------------
r102525 | mmichelson | 2008-02-05 16:57:53 -0600 (Tue, 05 Feb 2008) | 9 lines

Get rid of any remaining ast_verbose calls in the code in favor of
ast_verb

(closes issue ASTERISK-11385)
Reported by: mvanbaak
Patches:
     20080205_astverb-2.diff.txt uploaded by mvanbaak (license 7)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=102525