| Summary: | ASTERISK-11372: dtmf buffer not cleaned when hangup | ||
| Reporter: | Eduardo Ferro (eferro) | Labels: | |
| Date Opened: | 2008-02-04 10:25:33.000-0600 | Date Closed: | 2008-02-05 14:00:53.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_mgcp |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) mgcp_dtmfclean_on_hangup.diff | |
| Description: | When asterisk dial other extension, if you press some keys (during the dialing) and before the other side pick up the phone, you hangup the phone, the dtmf_buf is not cleared and after the On hook transition if you try to meke a new call you can see the initial numbers in the dtmf_buffer (so you call using a wrong number) ****** ADDITIONAL INFORMATION ****** To reproduce the error: 1) call some number 555777444 2) Asterisk Dial 3) (during dialing) press 678 4) On hook 5) Off hook 6) press for example 1 7) the following dial starts with 678 1... | ||
| Comments: | By: Eduardo Ferro (eferro) 2008-02-04 10:28:17.000-0600 The attached patch (mgcp_dtmfclean_on_hangup.diff) reset the dtmf_buf of the endpoint during the hangup function. It works for me in 1.4.17. By: Mark Michelson (mmichelson) 2008-02-05 13:55:08.000-0600 The patch you provided is reversed, and the places where you used spaces should instead use tabs, but since it's so small and it seems all right logically, I'll go ahead and get it merged. Please be careful to create patches properly in the future. Refer to the CODING-GUIDELINES document. Thanks for reporting the issue and thanks for the patch! By: Digium Subversion (svnbot) 2008-02-05 13:59:43.000-0600 Repository: asterisk Revision: 102453 U branches/1.4/channels/chan_mgcp.c ------------------------------------------------------------------------ r102453 | mmichelson | 2008-02-05 13:59:42 -0600 (Tue, 05 Feb 2008) | 8 lines Clear the DTMF buffer on hangup. (closes issue ASTERISK-11372) Reported by: eferro Patches: mgcp_dtmfclean_on_hangup.diff uploaded by eferro (license 337) Tested by: eferro ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=102453 By: Digium Subversion (svnbot) 2008-02-05 14:00:53.000-0600 Repository: asterisk Revision: 102454 _U trunk/ U trunk/channels/chan_mgcp.c ------------------------------------------------------------------------ r102454 | mmichelson | 2008-02-05 14:00:52 -0600 (Tue, 05 Feb 2008) | 16 lines Merged revisions 102453 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r102453 | mmichelson | 2008-02-05 14:02:44 -0600 (Tue, 05 Feb 2008) | 8 lines Clear the DTMF buffer on hangup. (closes issue ASTERISK-11372) Reported by: eferro Patches: mgcp_dtmfclean_on_hangup.diff uploaded by eferro (license 337) Tested by: eferro ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=102454 | ||