Summary: | ASTERISK-11353: [patch] Change argc != xx to argc != e->args [apps] | ||
Reporter: | jmls (jmls) | Labels: | |
Date Opened: | 2008-02-01 04:52:42.000-0600 | Date Closed: | 2008-02-08 15:37:16.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) apps.patch | |
Description: | looking through A101767, I saw a comment regarding the hardcoding of arguments. I have made changes to some (most) of the applications in apps to use the new syntax. e->args patch attached. ****** ADDITIONAL INFORMATION ****** I will do more files as and when I come across them | ||
Comments: | By: Jason Parker (jparker) 2008-02-01 10:46:18.000-0600 There are some cases where this is not appropriate. Example: sip_prune_realtime in chan_sip.c - see e->command By: jmls (jmls) 2008-02-01 11:00:06.000-0600 yeah, I looked at each one to see if it was appropriate. that's why I've only touched /apps/ at the moment By: Digium Subversion (svnbot) 2008-02-01 12:27:24.000-0600 Repository: asterisk Revision: 101872 U team/mvanbaak/cli-command-audit/apps/app_minivm.c U team/mvanbaak/cli-command-audit/apps/app_playback.c U team/mvanbaak/cli-command-audit/apps/app_rpt.c U team/mvanbaak/cli-command-audit/apps/app_voicemail.c ------------------------------------------------------------------------ r101872 | mvanbaak | 2008-02-01 12:27:23 -0600 (Fri, 01 Feb 2008) | 8 lines replace some more hardcoded argument numbers. (issue ASTERISK-11353) Reported by: jmls Patches: apps.patch uploaded by jmls (license 141) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=101872 By: Russell Bryant (russell) 2008-02-08 15:37:14.000-0600 It looks like all of these changes made it in as a part of the CLI command audit merge. Thanks! |