[Home]

Summary:ASTERISK-11341: function REALTIME() broken
Reporter:Sergey Tamkovich (sergee)Labels:
Date Opened:2008-01-31 06:04:50.000-0600Date Closed:2008-01-31 09:33:21.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Functions/func_realtime
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) func_realtime_fix-r101392.diff
Description:this error in code occured due to CODING-GUIDELINES. I believe that all blocks should be nested in braces , even if the block contains only 1 operator.

IMHO

if (a) {
printf("a");
}

is much better then

if (a)
printf("b");


1st variant will automaticly exclude problems like this one.
Comments:By: Sergey Tamkovich (sergee) 2008-01-31 06:54:49.000-0600

This bug was introduced in Revision 87263. Probably it also present in 1.4
By: Digium Subversion (svnbot) 2008-01-31 09:33:21.000-0600

Repository: asterisk
Revision: 101393

U   trunk/funcs/func_realtime.c

------------------------------------------------------------------------
r101393 | file | 2008-01-31 09:33:19 -0600 (Thu, 31 Jan 2008) | 6 lines

Add missing braces.
(closes issue ASTERISK-11341)
Reported by: sergee
Patches:
     func_realtime_fix-r101392.diff uploaded by sergee (license 138)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=101393