[Home]

Summary:ASTERISK-11317: Trunk requires externip=ip:port if bindport!=5060
Reporter:hmodes (hmodes)Labels:
Date Opened:2008-01-28 19:31:34.000-0600Date Closed:2008-01-29 17:37:50.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 100679_w_externip_bindaddr_Via_bug.rtf
Description:Contrary to the configs/sip.conf in trunk, which states (regarding externip=)

;      If a port number is not present, use the "bindport" value (which is
;      not guaranteed to work correctly, because a NAT box might remap the
;      port number as well as the address).

SVN-trunk-r100679M does _not_ append bindport to externip when creating a Via field on invite (see attached sip debug) but instead defaults to 5060.

This causes a natted sip client (cisco 7960 with nat_enable = 1) to transmit responses to the wrong port.  Specifying externip=ip:bindport causes the Via to be created with the correct port and the phone to respond correctly.

Relevant sip.conf general section:

[general]
context=default ; Default context for incoming calls
recordhistory=yes ; Record SIP history by default
realm=matrix.gs ; Realm for digest authentication
bindport=5066 ; UDP Port to bind to (SIP standard port is 5060)
bindaddr=0.0.0.0 ; IP address to bind to (0.0.0.0 binds to all)
srvlookup=yes ; Enable DNS SRV lookups on outbound calls
tos_audio=184
videosupport=no ; Turn on support for SIP video
sdpsession=session
allow=all
useragent=matrix.gs asterisk ; Allows you to change the user agent string
externip = *my external ip here w/o port specified*
localnet=172.27.28.0/255.255.255.0; All RFC 1918 addresses are local networks
Comments:By: Digium Subversion (svnbot) 2008-01-29 09:28:09.000-0600

Repository: asterisk
Revision: 100833

U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r100833 | file | 2008-01-29 09:28:08 -0600 (Tue, 29 Jan 2008) | 4 lines

Make externip work as documented. If no port is specified it will use the value of bindport instead of always being 5060.
(closes issue ASTERISK-11317)
Reported by: hmodes

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=100833
By: Digium Subversion (svnbot) 2008-01-29 17:37:50.000-0600

Repository: asterisk
Revision: 101077

_U  team/murf/bug11210/
U   team/murf/bug11210/Makefile
U   team/murf/bug11210/apps/app_queue.c
U   team/murf/bug11210/channels/chan_misdn.c
U   team/murf/bug11210/channels/chan_sip.c
U   team/murf/bug11210/channels/chan_zap.c
U   team/murf/bug11210/channels/misdn_config.c
U   team/murf/bug11210/main/Makefile
U   team/murf/bug11210/res/res_config_curl.c

------------------------------------------------------------------------
r101077 | murf | 2008-01-29 17:37:49 -0600 (Tue, 29 Jan 2008) | 190 lines

Merged revisions 100741,100767,100794-100795,100833,100843,100900,100928,100931,100933,100935,100974,101018,101036 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r100741 | oej | 2008-01-29 01:28:43 -0700 (Tue, 29 Jan 2008) | 3 lines

Removing code that wasn't supposed to be there at all, only at an experimental stage
before I found another solution. Thanks Kevin, for reminding me.

................
r100767 | oej | 2008-01-29 02:18:42 -0700 (Tue, 29 Jan 2008) | 16 lines

Merged revisions 100740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100740 | oej | 2008-01-29 09:26:48 +0100 (Tis, 29 Jan 2008) | 8 lines

(closes issue ASTERISK-11205)
Reported by: MVF
Patches:
     bug11736-2.diff uploaded by oej (license 306)
Tested by: oej, MVF, revolution

(russellb: This was the showstopper for the release.)

........

................
r100794 | crichter | 2008-01-29 03:47:06 -0700 (Tue, 29 Jan 2008) | 9 lines

Merged revisions 96199 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r96199 | crichter | 2008-01-03 13:12:27 +0100 (Do, 03 Jan 2008) | 1 line

make sure frame is completely clean, before we send it to asterisk as DTMF. If we don't make it clean, it happens that one way audio occurs..
........

................
r100795 | crichter | 2008-01-29 03:50:29 -0700 (Tue, 29 Jan 2008) | 9 lines

Merged revisions 100793 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100793 | crichter | 2008-01-29 11:36:19 +0100 (Di, 29 Jan 2008) | 1 line

fixed potential segfault in misdn show channels CLI command
........

................
r100833 | file | 2008-01-29 08:30:19 -0700 (Tue, 29 Jan 2008) | 4 lines

Make externip work as documented. If no port is specified it will use the value of bindport instead of always being 5060.
(closes issue ASTERISK-11317)
Reported by: hmodes

................
r100843 | qwell | 2008-01-29 09:14:08 -0700 (Tue, 29 Jan 2008) | 13 lines

Merged revisions 100835 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100835 | qwell | 2008-01-29 10:10:00 -0600 (Tue, 29 Jan 2008) | 5 lines

Allow zap groups above 30 to work properly.

(closes issue ASTERISK-11074)
Reported by: tbsky

........

................
r100900 | russell | 2008-01-29 10:16:34 -0700 (Tue, 29 Jan 2008) | 14 lines

Merged revisions 100882 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100882 | russell | 2008-01-29 11:06:43 -0600 (Tue, 29 Jan 2008) | 6 lines

Fix building Asterisk when the working path has spaces in it.

(closes issue ASTERISK-11295)
Reported by: spendergrass
Patched by: me

........

................
r100928 | russell | 2008-01-29 10:22:47 -0700 (Tue, 29 Jan 2008) | 11 lines

Merged revisions 100922 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100922 | russell | 2008-01-29 11:21:33 -0600 (Tue, 29 Jan 2008) | 3 lines

Use GNU make magic instead of shell magic to escape spaces in the working directory.
(related to issue ASTERISK-11295)

........

................
r100931 | qwell | 2008-01-29 10:42:48 -0700 (Tue, 29 Jan 2008) | 14 lines

Merged revisions 100930 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100930 | qwell | 2008-01-29 11:41:43 -0600 (Tue, 29 Jan 2008) | 6 lines

Initialize an array to 0s if config option not specified.

(closes issue ASTERISK-11319)
Patches:
     misdn_get_config.v1.diff uploaded by IgorG (license 20)

........

................
r100933 | russell | 2008-01-29 10:44:05 -0700 (Tue, 29 Jan 2008) | 12 lines

Merged revisions 100932 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100932 | russell | 2008-01-29 11:43:41 -0600 (Tue, 29 Jan 2008) | 4 lines

Fix the last couple of issues related to building from a path that contains spaces.

(closes issue ASTERISK-11295)

........

................
r100935 | file | 2008-01-29 10:58:37 -0700 (Tue, 29 Jan 2008) | 11 lines

Blocked revisions 100934 via svnmerge

........
r100934 | file | 2008-01-29 13:57:05 -0400 (Tue, 29 Jan 2008) | 4 lines

Don't forget to record the channel so we know whether it is bridged or not later.
(closes issue ASTERISK-11275)
Reported by: slavon

........

................
r100974 | mmichelson | 2008-01-29 12:41:42 -0700 (Tue, 29 Jan 2008) | 14 lines

Merged revisions 100973 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r100973 | mmichelson | 2008-01-29 13:39:00 -0600 (Tue, 29 Jan 2008) | 6 lines

Fixing an erroneous return value returned when attempting to pause or unpause a queue member
fails.

Fixes BE-366, thanks to John Bigelow for writing the patch.


........

................
r101018 | tilghman | 2008-01-29 15:04:15 -0700 (Tue, 29 Jan 2008) | 2 lines

Oops, a sizeof error

................
r101036 | mmichelson | 2008-01-29 16:02:48 -0700 (Tue, 29 Jan 2008) | 11 lines

Merged revisions 101035 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r101035 | mmichelson | 2008-01-29 17:02:03 -0600 (Tue, 29 Jan 2008) | 3 lines

Remove a memory leak from updating realtime queues


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=101077