Summary:ASTERISK-11310: Minor "appearance" improvements
Reporter:Pavol Luptak (wilder)Labels:
Date Opened:2008-01-26 14:32:18.000-0600Date Closed:2008-01-30 05:20:56.000-0600
Versions:Frequency of
Environment:Attachments:( 0) sip-show-peers-callerid2.patch
Description:I wrote simple patch, that :

- shows column "callerid" in "sip show peers" if "callerid" is set per peer (which is practical)
- shows no "callerid" in "sip show peer xxx" if "callerid" is not set (currently "" <> is displayed)

Comments:By: Tilghman Lesher (tilghman) 2008-01-26 19:06:48.000-0600

For the practical consideration of the screen being 80 columns wide, output is by design restricted to 80 columns.  Please reduce the width of your patch to output a maximum of 80 columns per line (you've exceeded 80 columns by at least 10 characters, by my count).

By: pj (pj) 2008-01-27 03:33:22.000-0600

what about to leave 'sip show peers' intact and add 'verbose' argument to display callerid? it will be least intrusive and gives possibility to users controlling asterisk from remote terminals with higher resolution.
anyway, displaying callerid will be helpfull feature for most people, I will be glad, if it appers in upcomming asterisk 1.6

By: Olle Johansson (oej) 2008-01-27 04:45:03.000-0600

We can't expand "sip show peers" much more (as Corydon76 points out), and everyone will have different opinions. That's why we have "sip show peer" to show ALL information. To make custom lists, you can always get the information you want via the manager interface.

By: pj (pj) 2008-01-27 04:52:20.000-0600

why you don't want to add verbose summary output 'sip show peers verbose' to display callerid? as we have eg. 'core show channels verbose', that outputs also much more than 80 columns?

By: Olle Johansson (oej) 2008-01-27 04:54:22.000-0600

To be honest, I personally don't see the point. We will have to continue adding to that forever, when we already have multiple list formats. If so, we have to make something that is configurable so that everyone can add their favorite information.

By: pj (pj) 2008-01-27 05:11:26.000-0600

I think, manager interface isn't suitable for getting informations quickly and in simple way as we can do with cli. Even I think, that most asterisk administrators, that doesn't use some gui, have ami turned off completely.

By: Olle Johansson (oej) 2008-01-30 05:20:55.000-0600

At this point, we have decided not to move the patch forward. Thanks for your contribution!