[Home]

Summary:ASTERISK-11289: [patch] Log that format does not exists when it is no true
Reporter:Igor Goncharovsky (igorg)Labels:
Date Opened:2008-01-23 22:38:25.000-0600Date Closed:2008-02-19 15:35:13.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Resources/res_convert
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) readfile.v1.diff
Description:This patch fix logging when file can not be opened.

Also I change 'continue' to 'break' because in this situation we have already fount needed format in list, but can't open file. We no need to continue search.

****** ADDITIONAL INFORMATION ******

server-voip*CLI> file convert /var/lib/asterisk/sounds/ru-1/*.sln /var/lib/asterisk/sounds/ru-1/*.g729
Unable to open input file: /var/lib/asterisk/sounds/ru-1/*.sln
Command 'file convert /var/lib/asterisk/sounds/ru-1/*.sln /var/lib/asterisk/sounds/ru-1/*.g729' failed.
[Jan 24 10:39:59] WARNING[3555]: file.c:874 ast_readfile: Unable to open /var/lib/asterisk/sounds/ru-1/*.sln
[Jan 24 10:39:59] WARNING[3555]: file.c:894 ast_readfile: No such format 'sln'

Comments:By: Digium Subversion (svnbot) 2008-02-19 15:35:13.000-0600

Repository: asterisk
Revision: 103827

U   trunk/main/file.c

------------------------------------------------------------------------
r103827 | file | 2008-02-19 15:35:12 -0600 (Tue, 19 Feb 2008) | 6 lines

Only output a log message saying the format does not exist if it actually does not exist, not if the file itself could not be opened.
(closes issue ASTERISK-11289)
Reported by: IgorG
Patches:
     readfile.v1.diff uploaded by IgorG (license 20)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103827