[Home]

Summary:ASTERISK-11270: Make File- Warning out of order
Reporter:James Finstrom (jfinstrom)Labels:
Date Opened:2008-01-20 16:54:48.000-0600Date Closed:2011-06-07 14:10:50
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 200801200_bug_11802.diff
Description:The full warning should come after 551 to ensure it is seen and doesnt just scroll past


540 oldmodcheck:
 541 @if [ -n "$(OLDMODS)" ]; then \
 542 echo " WARNING WARNING WARNING" ;\
 543 echo "" ;\
 544 echo " Your Asterisk modules directory, located at" ;\
 545 echo " $(DESTDIR)$(MODULES_DIR)" ;\
 546 echo " contains modules that were not installed by this " ;\
 547 echo " version of Asterisk. Please ensure that these" ;\
 548 echo " modules are compatible with this version before" ;\
 549 echo " attempting to run Asterisk." ;\
 550 echo "" ;\
 551 for f in $(OLDMODS); do \
 552 echo "    $$f" ;\
 553 done ;\
 554 echo "" ;\
 555 echo " WARNING WARNING WARNING" ;\
 556 fi
 557
Comments:By: Michiel van Baak (mvanbaak) 2008-01-20 17:13:22.000-0600

I replicated the warning after the module list.
How about that ?
By: Jason Parker (jparker) 2008-01-21 10:14:45.000-0600

I don't really understand how moving the text would help the situation at all - in fact, if the reasons for moving it are because you *can't* scroll up, then I could see this as being harmful.

Let's assume that you are able to see 16 lines on your screen.  The warning itself takes up 11 of those lines, leaving 5 lines for modules.  Let's say you have 10 modules that weren't compiled with Asterisk...  if you move the warning text to below the modules, you can no longer see some of the modules.  That's bad.

If the reason for this is just because people don't know that they need to scroll up to see it, I think the "WARNING WARNING WARNING" at the end serves as a pretty good indicator..


Closing.  Reopen if you think you can convince me.