| Summary: | ASTERISK-11251: Via header in responses might get truncated | ||
| Reporter: | Ofir Roval (ofirroval) | Labels: | |
| Date Opened: | 2008-01-17 05:03:58.000-0600 | Date Closed: | 2008-01-21 09:59:32.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | Following some interoperability tests we did between Asterisk and Avaya equipment, I noticed that the Via header in responses sometimes get truncated. For example, here is a Via header taken from a request sent from Avaya server to Asterisk: Via: SIP/2.0/UDP 149.49.82.150:5060;branch=z9hG4bK838383030303333333460.0,SIP/2.0/TLS 149.49.82.150:6002;psrrposn=2;received=149.49.82.150;branch=z9hG4bK803034a38b7dc15a1477a6e6600,SIP/2.0/TCP 149.49.82.150:6005;psrrposn=1;received=149.49.82.150;branch=z9hG4bK984ad723672d6072 A provisional response from Asterisk to this request had the following Via header: Via: SIP/2.0/UDP 149.49.82.150:5060;branch=z9hG4bK838383030303333333460.0;received=149.49.82.150,SIP/2.0/TLS 149.49.82.150:6002;psrrposn=2;received=149.49.82.150;branch=z9hG4bK803034a38b7dc15a1477a6e6600,SIP/2.0/TCP 149.49.82.150:6005;psrrposn=1;received=149.4 Note that on the last Via segment, the "received" parameter is truncated and the "branch" parameter is missing. I noticed that this behavior is somehow related to the lengths of "branch" parameters, and possibly the overall length of the Via header. I believe it can be easily reproduced using some simple sipp scenario. Since I am not an Asterisk developer I don't have further insight on this issue but I would gladly supply more information if needed. ****** ADDITIONAL INFORMATION ****** Asterisk was running on Linux 2.6.19, Asterisk build 1.4.5. | ||
| Comments: | By: Digium Subversion (svnbot) 2008-01-21 09:58:25.000-0600 Repository: asterisk Revision: 99301 U branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r99301 | file | 2008-01-21 09:58:24 -0600 (Mon, 21 Jan 2008) | 4 lines Bump the buffer size for Via headers up to 512. There are some exceptionally large Via headers out there. (closes issue ASTERISK-11251) Reported by: ofirroval ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=99301 By: Digium Subversion (svnbot) 2008-01-21 09:59:32.000-0600 Repository: asterisk Revision: 99302 _U trunk/ U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r99302 | file | 2008-01-21 09:59:31 -0600 (Mon, 21 Jan 2008) | 12 lines Merged revisions 99301 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r99301 | file | 2008-01-21 12:01:00 -0400 (Mon, 21 Jan 2008) | 4 lines Bump the buffer size for Via headers up to 512. There are some exceptionally large Via headers out there. (closes issue ASTERISK-11251) Reported by: ofirroval ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=99302 | ||