[Home]

Summary:ASTERISK-11192: [patch] core show translation listing unknown non-voice codecs
Reporter:Caio Begotti (caio1982)Labels:
Date Opened:2008-01-09 20:01:12.000-0600Date Closed:2008-01-10 18:53:32.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) show_translation_unknown1.diff
Description:Issuing 'core show translation' is listing two unknown non-voice codecs. Seems it was introduced after adding slin16 to the list, I don't know if the increasing of SHOW_TRANS directly to 16 is better though. I hope this is the proper way to fix it!

****** ADDITIONAL INFORMATION ******

Samples output after and before at http://pastebin.com/f7a73c18d
Comments:By: Russell Bryant (russell) 2008-01-09 20:27:18.000-0600

This is probably ok, but only if SLINEAR16 is _not_ in Asterisk 1.4.  If so, we can't change it ...
By: Russell Bryant (russell) 2008-01-09 20:28:58.000-0600

Ok, it's not in 1.4 ... but I'm still not sure if we should change it.  It's in the last codec bit because it's not really a codec.  It's really a hack, and it was probably done this way to leave the lower bits for "real" codecs.
By: Caio Begotti (caio1982) 2008-01-09 20:37:14.000-0600

Hmm but the regular SLINEAR is in the same list inside frame.h as a real codec, Russell, I don't get it. Is there any difference between them that make slin16 not a real codec? Sorry for this reallly newbie question :)
By: Caio Begotti (caio1982) 2008-01-09 21:29:21.000-0600

I've read your codec_resample code but in practice they're handled as different codecs under normal operation, or not?
By: Digium Subversion (svnbot) 2008-01-10 18:53:32.000-0600

Repository: asterisk
Revision: 98047

U   trunk/main/translate.c

------------------------------------------------------------------------
r98047 | mmichelson | 2008-01-10 18:53:31 -0600 (Thu, 10 Jan 2008) | 7 lines

Fix "core show translation" to not output information for "unknown" codecs.
This fix was made in favor of the proposed patch since it doesn't involve changing
a core codec define.

(closes issue ASTERISK-11192, reported and initially patched by caio1982, final patch by me)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=98047