[Home]

Summary:ASTERISK-11177: [patch] code cleanup: remove not maintained pbx_kdeconsole and pbx_gtkconsole from tree
Reporter:Caio Begotti (caio1982)Labels:
Date Opened:2008-01-07 21:40:36.000-0600Date Closed:2008-01-10 10:13:52.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:PBX/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) kde_gtk_cleanup5.diff
Description:pbx_kdeconsole seems not maintained since ages, only 7 commits so far and the last one is more than 1,5 year ago and it does not build cleanly on Linux. Actually I could not build it even working around
warnings and errors at all: like running moc manually, which was not done by Asterisk building. The libqt checking seems not to be working properly as well.

pbx_gtkconsole only received simple maintaining changes commited for a lot of files, very rarely directly to it to fix an issue. The same applies here: last real commit was almost 1,5 ago by russell to be
able to at least build and load it. I tried to build and use it on OSX and could not.

Is there anyone really using these modules? If so, how? I suppose the most people can use right now is pbx_gtkconsole, with no guarantee of success, that's for sure. I guess they should be removed from the tree because their functionality can be accomplished by using AMI, there's no real need to keep more than one kind of remote console, and KDE 4.x already provides a Plasmoid API for monitoring with a CLI-like if one still wants it.

I almost can bet there's nobody using these modules, saying it from the lack of any bug report about any of them recently.

Comments? Anybody against it for some obvious reason?

****** ADDITIONAL INFORMATION ******

PBX/pbx_gtkconsole is available for Category selection, but PBX/pbx_kdeconsole is not. Hence it's quite hard to search for bugs categorized to it on Mantis.

Deleted files, just to make sure (I've got a weird 'M' result from svn
when simply patching them blank so it's safer to remove them with svn del):

D      pbx/pbx_kdeconsole.cc
D      pbx/pbx_kdeconsole.h
D      pbx/pbx_gtkconsole.c
D      pbx/kdeconsole_main.cc
Comments:By: Caio Begotti (caio1982) 2008-01-07 21:41:45.000-0600

Those guys have done this much earlier, not a bad idea anyway :-)
http://lists.callweaver.org/pipermail/callweaver-svn/2005-October/000188.html
By: Caio Begotti (caio1982) 2008-01-07 21:43:12.000-0600

Mail just sent to the asterisk-dev list for proper discussion:
http://www.mail-archive.com/asterisk-dev@lists.digium.com/msg30670.html
By: Russell Bryant (russell) 2008-01-07 23:17:54.000-0600

I'm ok with deleting pbx_kdeconsole.  That thing hasn't built in ages and nobody seems to have complained.  However, I'd like to keep pbx_gtkconsole.  It should be trivial to get building properly if it isn't building already.  Also, I don't mind fixing it if it is needed.
By: Caio Begotti (caio1982) 2008-01-08 04:20:14.000-0600

I'll try to work on and test pbx_gtkconsole too then, I didn't insist too much on it since my environment at work is mostly KDE.
By: Digium Subversion (svnbot) 2008-01-09 16:24:24.000-0600

Repository: asterisk
Revision: 97640

U   branches/1.4/pbx/pbx_gtkconsole.c

------------------------------------------------------------------------
r97640 | russell | 2008-01-09 16:24:21 -0600 (Wed, 09 Jan 2008) | 3 lines

Make pbx_gtkconsole build ... but doesn't actually load on my system still
(related to issue ASTERISK-11177)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=97640
By: Digium Subversion (svnbot) 2008-01-09 16:25:37.000-0600

Repository: asterisk
Revision: 97641

_U  trunk/
U   trunk/pbx/pbx_gtkconsole.c

------------------------------------------------------------------------
r97641 | russell | 2008-01-09 16:25:36 -0600 (Wed, 09 Jan 2008) | 11 lines

Merged revisions 97640 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r97640 | russell | 2008-01-09 16:26:33 -0600 (Wed, 09 Jan 2008) | 3 lines

Make pbx_gtkconsole build ... but doesn't actually load on my system still
(related to issue ASTERISK-11177)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=97641
By: Digium Subversion (svnbot) 2008-01-09 16:49:12.000-0600

Repository: asterisk
Revision: 97643

U   trunk/configure.ac

------------------------------------------------------------------------
r97643 | russell | 2008-01-09 16:49:05 -0600 (Wed, 09 Jan 2008) | 3 lines

re-add check for gtk1, which is used for pbx_gtkconsole
(related to issue ASTERISK-11177)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=97643
By: Digium Subversion (svnbot) 2008-01-10 10:09:57.000-0600

Repository: asterisk
Revision: 97734

U   branches/1.4/build_tools/menuselect-deps.in
U   branches/1.4/configure
U   branches/1.4/configure.ac
U   branches/1.4/include/asterisk/autoconfig.h.in
U   branches/1.4/makeopts.in
D   branches/1.4/pbx/pbx_kdeconsole.cc

------------------------------------------------------------------------
r97734 | russell | 2008-01-10 10:09:55 -0600 (Thu, 10 Jan 2008) | 4 lines

Remove pbx_kdeconsole from the tree.  It hasn't worked in ages, and nobody has
complained.
(closes issue ASTERISK-11177, reported by caio1982)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=97734
By: Digium Subversion (svnbot) 2008-01-10 10:13:52.000-0600

Repository: asterisk
Revision: 97745

_U  trunk/
U   trunk/build_tools/menuselect-deps.in
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in
U   trunk/makeopts.in
D   trunk/pbx/pbx_kdeconsole.cc

------------------------------------------------------------------------
r97745 | russell | 2008-01-10 10:13:51 -0600 (Thu, 10 Jan 2008) | 12 lines

Merged revisions 97734 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r97734 | russell | 2008-01-10 10:10:09 -0600 (Thu, 10 Jan 2008) | 4 lines

Remove pbx_kdeconsole from the tree.  It hasn't worked in ages, and nobody has
complained.
(closes issue ASTERISK-11177, reported by caio1982)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=97745