[Home]

Summary:ASTERISK-11148: [patch] information stored before unlock, but not used
Reporter:Frederic LE FOLL (flefoll)Labels:
Date Opened:2008-01-04 02:16:20.000-0600Date Closed:2008-01-04 10:17:27.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_zap.c.patch-store-owner-before-unlock
Description:Calls to pbx_builtin_setvar_helper() now are surrounded by pvt unlock/lock, and pvt owner is stored in a new "owner" local variable before unlock, but this variable is not used when calling pbx_builtin_setvar_helper().

I propose a patch in order to use "owner" local variable instead of reading unlocked pvt.
Comments:By: Digium Subversion (svnbot) 2008-01-04 10:15:43.000-0600

Repository: asterisk
Revision: 96449

U   branches/1.4/channels/chan_zap.c

------------------------------------------------------------------------
r96449 | russell | 2008-01-04 10:15:42 -0600 (Fri, 04 Jan 2008) | 7 lines

Make use of the temporary channel pointer while the pvt is unlocked.

(closes issue ASTERISK-11148)
Reported by: flefoll
Patches:
     chan_zap.c.patch-store-owner-before-unlock uploaded by flefoll (license 244)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=96449
By: Digium Subversion (svnbot) 2008-01-04 10:17:27.000-0600

Repository: asterisk
Revision: 96450

_U  trunk/
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r96450 | russell | 2008-01-04 10:17:27 -0600 (Fri, 04 Jan 2008) | 15 lines

Merged revisions 96449 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r96449 | russell | 2008-01-04 10:19:22 -0600 (Fri, 04 Jan 2008) | 7 lines

Make use of the temporary channel pointer while the pvt is unlocked.

(closes issue ASTERISK-11148)
Reported by: flefoll
Patches:
     chan_zap.c.patch-store-owner-before-unlock uploaded by flefoll (license 244)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=96450