[Home]

Summary:ASTERISK-11124: [patch] correct action_ping() and action_events(), to set correct header in responce.
Reporter:Yuri (ys)Labels:
Date Opened:2007-12-28 07:08:05.000-0600Date Closed:2008-04-22 11:55:32
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) trunk_manager.c.diff
Description:As declared in doc/manager_1_1.txt I correct response in action_ping() and action_events() functions.

From:

Response: Success
Message: Ping: Pong
and
Response: Success
Message: Events: Off/On

to:

Response: Success
Ping: Pong
and
Response: Success
Events: Off/On

accordingly...


****** ADDITIONAL INFORMATION ******


Also add small check to xml_translate, to avoid
"ERROR[45448]: astobj2.c:109 INTERNAL_OBJ: user_data is NULL"
message and incorrect xml/html formating for this manager action.


Also, ajam interface need to be updated according changes in doc/manager_1_1.txt.
Comments:By: Olle Johansson (oej) 2007-12-28 07:45:21.000-0600

Thanks. Must have missed porting that part over from the branch.
By: jmls (jmls) 2008-02-06 04:19:56.000-0600

was this added to trunk ?
By: Yuri (ys) 2008-02-06 05:07:56.000-0600

still not added.
By: Digium Subversion (svnbot) 2008-04-22 10:40:52

Repository: asterisk
Revision: 114527

U   trunk/main/manager.c

------------------------------------------------------------------------
r114527 | russell | 2008-04-22 10:40:51 -0500 (Tue, 22 Apr 2008) | 8 lines

Correct action_ping() and action_events() with regards to Manager 1.1
documentation.  Also, fix a bug in xml_translate().

(closes issue ASTERISK-11124)
Reported by: ys
Patches:
     trunk_manager.c.diff uploaded by ys (license 281)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114527
By: Digium Subversion (svnbot) 2008-04-22 10:41:28

Repository: asterisk
Revision: 114528

_U  branches/1.6.0/
U   branches/1.6.0/main/manager.c

------------------------------------------------------------------------
r114528 | russell | 2008-04-22 10:41:27 -0500 (Tue, 22 Apr 2008) | 16 lines

Merged revisions 114527 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r114527 | russell | 2008-04-22 10:46:01 -0500 (Tue, 22 Apr 2008) | 8 lines

Correct action_ping() and action_events() with regards to Manager 1.1
documentation.  Also, fix a bug in xml_translate().

(closes issue ASTERISK-11124)
Reported by: ys
Patches:
     trunk_manager.c.diff uploaded by ys (license 281)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114528
By: Digium Subversion (svnbot) 2008-04-22 11:55:32

Repository: asterisk
Revision: 114535

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/CHANGES
U   team/seanbright/resolve-shadow-warnings/apps/app_jack.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_sip.c
U   team/seanbright/resolve-shadow-warnings/configs/sip_notify.conf.sample
U   team/seanbright/resolve-shadow-warnings/main/manager.c
U   team/seanbright/resolve-shadow-warnings/main/utils.c

------------------------------------------------------------------------
r114535 | seanbright | 2008-04-22 11:55:30 -0500 (Tue, 22 Apr 2008) | 73 lines

Merged revisions 114520,114523,114527,114529,114533 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r114520 | murf | 2008-04-22 10:38:46 -0400 (Tue, 22 Apr 2008) | 15 lines


Hopefully, this will resolve the issues that russellb had with this log_show_lock().
I gathered the code that filled the string, and put it in a different func which
I cryptically call "append_lock_information()".
Now, both log_show_lock(), and handle_show_locks() both call this code to do
the work. Tested, seems to work fine.
Also, log_show_lock was modified to use the ast_str stuff, along with checking
for successful ast_str creation, and freeing the ast_str obj when finished.
A break was inserted to terminate the search for the lock; we should never
see it twice.

An example usage in chan_sip.c was created as a comment, for instructional
purposes.


................
r114523 | russell | 2008-04-22 11:20:53 -0400 (Tue, 22 Apr 2008) | 20 lines

Blocked revisions 114522 via svnmerge

........
r114522 | russell | 2008-04-22 10:20:37 -0500 (Tue, 22 Apr 2008) | 13 lines

Merge changes from team/russell/issue_9520

These changes make sure that the reference count for sip_peer objects properly
reflects the fact that the peer is sitting in the scheduler for a scheduled
callback for qualifying peers or for expiring registrations.  Without this, it
was possible for these callbacks to happen at the same time that the peer was
being destroyed.  This was especially likely to happen with realtime peers, and
for people making use of the realtime prune CLI command.

(closes issue ASTERISK-9243)
Reported by: kryptolus
Committed patch by me

........

................
r114527 | russell | 2008-04-22 11:46:01 -0400 (Tue, 22 Apr 2008) | 8 lines

Correct action_ping() and action_events() with regards to Manager 1.1
documentation.  Also, fix a bug in xml_translate().

(closes issue ASTERISK-11124)
Reported by: ys
Patches:
     trunk_manager.c.diff uploaded by ys (license 281)

................
r114529 | file | 2008-04-22 11:54:06 -0400 (Tue, 22 Apr 2008) | 6 lines

Add support for authenticating on a NOTIFY request. This is useful for phones that require it when sending them a special packet to get them to do something (such as reload their configuration).
(closes issue ASTERISK-9602)
Reported by: IgorG
Patches:
     sipnotify-113980-v14.patch uploaded by IgorG (license 20)

................
r114533 | russell | 2008-04-22 12:47:00 -0400 (Tue, 22 Apr 2008) | 4 lines

Add a c() option for the Jack() application and JACK_HOOK() funciton for supplying
a custom client name.  Using the channel name is still the default.  This was done
at the request of Jared Smith.

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114535