Summary:	ASTERISK-11095: [patch] Email notification for forwarded voicemail doesn't set VM_DUR properly
Reporter:	James McCoy (jamessan)	Labels:
Date Opened:	2007-12-21 13:02:39.000-0600	Date Closed:	2008-07-15 08:25:16
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 20071226__bug11615__2.diff.txt ( 1) vm_dur.diff
Description:	When a user has email notification enabled, VM_DUR always expands to 0 for a voicemail forwarded to them unless the voicemail also has a message prepended to it.  It's fairly straightforward to fix, so I've included a patch.  The patch also removes a section of dead code (the '*' case in the switch statement) in that function.
Comments:	By: Tilghman Lesher (tilghman) 2007-12-24 15:56:49.000-0600 This is clearly a bug in 1.4, as is the issue with being unable to back out of a prepend (a second attempt at a prepend does not delete what was added during the first prepend), so I'm backporting the fix to 1.4. By: Tilghman Lesher (tilghman) 2008-01-28 15:18:34.000-0600 I need some testing feedback on this patch, please. By: James McCoy (jamessan) 2008-02-01 15:03:07.000-0600 Just did some testing and both the voicemail duration in the notification email and maintaining the original voicemail when prepending for a forward are working properly. By: Digium Subversion (svnbot) 2008-02-01 15:51:33.000-0600 Repository: asterisk Revision: 101942 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r101942 | tilghman | 2008-02-01 15:51:32 -0600 (Fri, 01 Feb 2008) | 8 lines Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugs while I'm in the area. (closes issue ASTERISK-11095) Reported by: jamessan Patches:       20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=101942 By: Digium Subversion (svnbot) 2008-02-01 16:09:59.000-0600 Repository: asterisk Revision: 101943 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r101943 | tilghman | 2008-02-01 16:09:59 -0600 (Fri, 01 Feb 2008) | 16 lines Merged revisions 101942 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101942 | tilghman | 2008-02-01 15:54:28 -0600 (Fri, 01 Feb 2008) | 8 lines Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugs while I'm in the area. (closes issue ASTERISK-11095) Reported by: jamessan Patches:       20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=101943 By: Digium Subversion (svnbot) 2008-02-01 16:33:29.000-0600 Repository: asterisk Revision: 101988 _U  team/tilghman/res_odbc_astobj2/ U   team/tilghman/res_odbc_astobj2/apps/app_authenticate.c U   team/tilghman/res_odbc_astobj2/apps/app_voicemail.c U   team/tilghman/res_odbc_astobj2/configs/res_odbc.conf.sample U   team/tilghman/res_odbc_astobj2/configure U   team/tilghman/res_odbc_astobj2/configure.ac U   team/tilghman/res_odbc_astobj2/include/asterisk/autoconfig.h.in U   team/tilghman/res_odbc_astobj2/res/res_config_curl.c U   team/tilghman/res_odbc_astobj2/res/res_odbc.c ------------------------------------------------------------------------ r101988 | tilghman | 2008-02-01 16:33:28 -0600 (Fri, 01 Feb 2008) | 88 lines Merged revisions 101819,101821,101823-101824,101869,101873,101895,101943 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r101819 | russell | 2008-02-01 11:26:31 -0600 (Fri, 01 Feb 2008) | 12 lines Merged revisions 101818 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101818 | russell | 2008-02-01 11:23:47 -0600 (Fri, 01 Feb 2008) | 4 lines Don't overwrite the last character of a line if it's not a newline.  This would happen if the last line in the file doesn't have a newline. (pointed out by Qwell) ........ ................ r101821 | russell | 2008-02-01 11:28:06 -0600 (Fri, 01 Feb 2008) | 8 lines Blocked revisions 101820 via svnmerge ........ r101820 | russell | 2008-02-01 11:27:02 -0600 (Fri, 01 Feb 2008) | 1 line off by one error ........ ................ r101823 | qwell | 2008-02-01 11:44:32 -0600 (Fri, 01 Feb 2008) | 3 lines Move an feof() call to before the fgets(). This would have exited the loop early if you had an authentication file with no newline at the end. ................ r101824 | tilghman | 2008-02-01 12:08:44 -0600 (Fri, 01 Feb 2008) | 2 lines Clarify the pooling functionality by changing the config file keyword ................ r101869 | qwell | 2008-02-01 12:24:52 -0600 (Fri, 01 Feb 2008) | 1 line Comparison, not set :)  Thanks mvanbaak. ................ r101873 | tilghman | 2008-02-01 12:45:31 -0600 (Fri, 01 Feb 2008) | 7 lines Fix multi, when using the LIKE query. (closes issue ASTERISK-11344) Reported by: jmls Patches:       res_config_curl.patch uploaded by jmls (license 141) Tested by: jmls ................ r101895 | tilghman | 2008-02-01 13:44:39 -0600 (Fri, 01 Feb 2008) | 10 lines Merged revisions 101894 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101894 | tilghman | 2008-02-01 13:36:12 -0600 (Fri, 01 Feb 2008) | 2 lines Change detection of getifaddrs to use AST_C_COMPILE_CHECK, backported from trunk (as suggested by kpfleming) ........ ................ r101943 | tilghman | 2008-02-01 16:12:55 -0600 (Fri, 01 Feb 2008) | 16 lines Merged revisions 101942 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r101942 | tilghman | 2008-02-01 15:54:28 -0600 (Fri, 01 Feb 2008) | 8 lines Fix the VM_DUR variable for forwarded voicemail, and fixed several other bugs while I'm in the area. (closes issue ASTERISK-11095) Reported by: jamessan Patches:       20071226__bug11615__2.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, jamessan ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=101988