[Home]

Summary:ASTERISK-11081: [patch] syntax fix for both brazilian and european portuguese (reported for SayUnixTime and VoiceMailMain)
Reporter:Caio Begotti (caio1982)Labels:
Date Opened:2007-12-19 09:15:37.000-0600Date Closed:2007-12-21 10:07:49.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 1.4.16_pt_BR_say.diff
Description:This should make Asterisk playback much better dates and times in Portuguese. Until this brazilian portuguese was playbacking a repeated 'digits/at', for instance (one in english and another following in portuguese).

I wonder why nobody complained about it before but thanks for Victor_Yure from Asterisk Brasil for testing this, looks pretty fine (we even tested using 'pt', european, to make sure it won't downgrade anyone in Europe).

****** ADDITIONAL INFORMATION ******

     Executing [1515@tradein:1] SayUnixTime("SIP/6268-08255198", "") in new stack
         -- <SIP/6268-08255198> Playing 'digits/day-3' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/19' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-de' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/mon-11' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-de' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/2' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/1000' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-e' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/7' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-ao' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-meiodia' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/pt-e' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/1' (language 'pt_BR')
         -- <SIP/6268-08255198> Playing 'digits/minute' (language 'pt_BR')
         -- Executing [1515@tradein:2] Hangup("SIP/6268-08255198", "") in new stack



     Executing [1515@tradein:1] SayUnixTime("SIP/6268-08255198", "") in new stack
         -- <SIP/6268-08255198> Playing 'digits/day-3' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/19' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-de' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/mon-11' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-de' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/2' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/1000' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-e' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/7' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-ah' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-sss' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/11' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-e' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/50' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/pt-e' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/9' (language 'pt')
         -- <SIP/6268-08255198> Playing 'digits/a-m' (language 'pt')
Comments:By: Caio Begotti (caio1982) 2007-12-19 15:44:24.000-0600

The patch was made for a 1.4.16 box as some users reported it as affecting branch 1.4.x but it also fits trunk and have to me merged there too :)
By: Victor Yure (victoryure) 2007-12-21 08:51:00.000-0600

I'm a native brazillian portuguese speaker, i've tested the patch and it really improved things a lot
By: Digium Subversion (svnbot) 2007-12-21 09:41:59.000-0600

Repository: asterisk
Revision: 94420

U   branches/1.4/apps/app_queue.c
U   branches/1.4/main/say.c

------------------------------------------------------------------------
r94420 | mmichelson | 2007-12-21 09:41:58 -0600 (Fri, 21 Dec 2007) | 5 lines

Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup.

(closes issue ASTERISK-11081, reported and patched by caio1982, coding guidelines cleanup by me)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=94420
By: Digium Subversion (svnbot) 2007-12-21 10:07:49.000-0600

Repository: asterisk
Revision: 94463

_U  trunk/
U   trunk/apps/app_queue.c
U   trunk/main/say.c

------------------------------------------------------------------------
r94463 | mmichelson | 2007-12-21 10:07:49 -0600 (Fri, 21 Dec 2007) | 13 lines

Merged revisions 94420 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r94420 | mmichelson | 2007-12-21 09:45:14 -0600 (Fri, 21 Dec 2007) | 5 lines

Fixing Portuguese syntax for saying dates and times. Also some coding guidelines cleanup.

(closes issue ASTERISK-11081, reported and patched by caio1982, coding guidelines cleanup by me)


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=94463