Summary:	ASTERISK-11073: Monitor and One Touch Recording call for "soxmix"
Reporter:	Anthony Messina (amessina)	Labels:
Date Opened:	2007-12-18 07:17:48.000-0600	Date Closed:	2007-12-19 17:01:21.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_monitor
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) res_monitor.c.diff
Description:	The binary "soxmix" used to mix two legs of a recorded call has been removed from sox since sox-13.0.0, but Monitor and Automon still call for this binary to mix the files. [Dec 18 06:59:51] DEBUG[31406]: res_monitor.c:316 ast_monitor_stop: monitor executing ( nice -n 19 soxmix "/var/spool/asterisk/monitor/auto-1197982775-2200-2200-in.wav" "/var/spool/asterisk/monitor/auto-1197982775-2200-2200-out.wav" "/var/spool/asterisk/monitor/auto-1197982775-2200-2200.wav"  && rm -f "/var/spool/asterisk/monitor/auto-1197982775-2200-2200-"* ) & ****** ADDITIONAL INFORMATION ****** See the sox changelog (line 170): http://sox.cvs.sourceforge.net/sox/sox/ChangeLog?view=markup
Comments:	By: Digium Subversion (svnbot) 2007-12-19 16:45:37.000-0600 Repository: asterisk Revision: 94077 U   branches/1.4/configure U   branches/1.4/configure.ac U   branches/1.4/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r94077 | russell | 2007-12-19 16:45:36 -0600 (Wed, 19 Dec 2007) | 4 lines Check for the existence of the soxmix application on the target platform and have the result available in autoconfig.h. (part of issue ASTERISK-11073) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94077 By: Digium Subversion (svnbot) 2007-12-19 16:48:03.000-0600 Repository: asterisk Revision: 94085 _U  trunk/ U   trunk/configure U   trunk/configure.ac U   trunk/include/asterisk/autoconfig.h.in ------------------------------------------------------------------------ r94085 | russell | 2007-12-19 16:48:02 -0600 (Wed, 19 Dec 2007) | 12 lines Merged revisions 94077 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r94077 | russell | 2007-12-19 16:48:48 -0600 (Wed, 19 Dec 2007) | 4 lines Check for the existence of the soxmix application on the target platform and have the result available in autoconfig.h. (part of issue ASTERISK-11073) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94085 By: Mark Michelson (mmichelson) 2007-12-19 16:57:29.000-0600 Just so it doesn't seem like you're being given the silent treatment, we discussed this bug, and since the sox -m option does not exist for sox versions earlier than 13.0.0, it's not safe to change the source to only use that. Instead, we have changed the configure script to check for the existence of soxmix. After my next commit, this issue will be closed. By: Digium Subversion (svnbot) 2007-12-19 17:00:07.000-0600 Repository: asterisk Revision: 94122 U   branches/1.4/res/res_monitor.c ------------------------------------------------------------------------ r94122 | mmichelson | 2007-12-19 17:00:06 -0600 (Wed, 19 Dec 2007) | 6 lines Sox versions 13.0.0 and newer do not have "soxmix" and instead use sox -m. res_monitor needs to use this if the user does not have soxmix. (closes issue ASTERISK-11073, reported by amessina, patch inspired by amessina but with a flourish from me) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94122 By: Digium Subversion (svnbot) 2007-12-19 17:01:21.000-0600 Repository: asterisk Revision: 94123 _U  trunk/ U   trunk/res/res_monitor.c ------------------------------------------------------------------------ r94123 | mmichelson | 2007-12-19 17:01:19 -0600 (Wed, 19 Dec 2007) | 14 lines Merged revisions 94122 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r94122 | mmichelson | 2007-12-19 17:02:22 -0600 (Wed, 19 Dec 2007) | 6 lines Sox versions 13.0.0 and newer do not have "soxmix" and instead use sox -m. res_monitor needs to use this if the user does not have soxmix. (closes issue ASTERISK-11073, reported by amessina, patch inspired by amessina but with a flourish from me) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94123