[Home]

Summary:ASTERISK-11019: [patch] Please increase MAX_SPANS ("Channel ___ does not lie on a span I know of")
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2007-12-12 11:12:15.000-0600Date Closed:2007-12-26 16:34:37.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) zap_num_spans.diff
Description:Upon testing a few digital spans along with many analog spans we occasionally get the message "Channel ___ does not lie on a span I know of".

The cause for that is simply that NUM_SPANS in channels/chan_zap.c is set to 32. Thus if the number of the digital span is >= 32, mkintf will fail to generate its channels.

Any major performance hit to increasing this value to ZT_MAX_SPANS?
Comments:By: Tilghman Lesher (tilghman) 2007-12-12 11:27:41.000-0600

No, just a memory hit.
By: Tzafrir Cohen (tzafrir) 2007-12-14 18:55:47.000-0600

Updated, to use proper constant from chan_zap (ZT_MAX_SPANS -- 128)

Note that ZT_MAX_SPANS is already used once in chan_zap.so when scanning all Zaptel spans at startup.
By: Digium Subversion (svnbot) 2007-12-26 16:34:37.000-0600

Repository: asterisk
Revision: 94818

U   trunk/build_tools/cflags.xml
U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r94818 | tilghman | 2007-12-26 16:34:37 -0600 (Wed, 26 Dec 2007) | 6 lines

Allow more spans than 32.  Also, rearrange compiler flags so the most often
used flags appear closer to the top.
Reported by: tzafrir
Patch by: tzafrir,tilghman
(Closes issue ASTERISK-11019)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=94818