[Home]

Summary:ASTERISK-11012: [patch] Re-enable one-touch parking on timeout park recall
Reporter:pliew (pliew)Labels:
Date Opened:2007-12-11 17:19:36.000-0600Date Closed:2008-02-29 20:02:17.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Resources/res_features
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_features.c.diff
Description:Simple patch to re-enable one-touch parking flag in addition to the existing transfer flag. Limitation: does not check to see if this option has been enabled in the first place from the original app
Comments:By: Terry Wilson (twilson) 2008-01-17 10:11:12.000-0600

I'm looking at this, now.  I'm not comfortable enabling an issue that might have not been there previously, but I am looking to see if there is a way to check this.  Looks like it might be a bit of work.

By: pliew (pliew) 2008-01-17 16:30:08.000-0600

Yes it was bugging me as well. But our customers were screaming so we put that in to re-enable it as a short term solution. I can see it potentially being a problem if released generally. As a suggestion, perhaps set a channel variable, whenever the "k" option is used in the "dial" and "queue" apps and test for that before re-enabling it. That way its also available to the dialplan for checking.

By: Digium Subversion (svnbot) 2008-02-29 19:27:23.000-0600

Repository: asterisk
Revision: 105477

_U  trunk/
U   trunk/apps/app_dial.c
U   trunk/include/asterisk/app.h
U   trunk/include/asterisk/global_datastores.h
U   trunk/main/app.c
U   trunk/main/features.c
U   trunk/main/global_datastores.c

------------------------------------------------------------------------
r105477 | twilson | 2008-02-29 19:27:22 -0600 (Fri, 29 Feb 2008) | 6 lines

Asterisk, when parking can drop rights a caller when a parking timeout occurs.  Also, when doing built-in attended transfers, sometimes incorrectly passes rights from the transferrer to the transferee.  This patch tries to fixes the parking issue and lays some groundwork for later fixing the transfer issue.

(closes issue ASTERISK-11012)
Reported by: pliew
Tested by: otherwiseguy

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=105477

By: Digium Subversion (svnbot) 2008-02-29 20:02:17.000-0600

Repository: asterisk
Revision: 105480

_U  team/tilghman/res_odbc_astobj2/
U   team/tilghman/res_odbc_astobj2/CHANGES
U   team/tilghman/res_odbc_astobj2/apps/app_dial.c
U   team/tilghman/res_odbc_astobj2/funcs/func_devstate.c
U   team/tilghman/res_odbc_astobj2/include/asterisk/app.h
U   team/tilghman/res_odbc_astobj2/include/asterisk/global_datastores.h
U   team/tilghman/res_odbc_astobj2/main/app.c
U   team/tilghman/res_odbc_astobj2/main/features.c
U   team/tilghman/res_odbc_astobj2/main/global_datastores.c

------------------------------------------------------------------------
r105480 | tilghman | 2008-02-29 20:02:16 -0600 (Fri, 29 Feb 2008) | 31 lines

Merged revisions 105461,105477,105479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
r105461 | russell | 2008-02-29 18:53:25 -0600 (Fri, 29 Feb 2008) | 9 lines

Add a "devstate change" CLI command to control custom device states.  Also,
do some additional code cleanup and improvement in passing.

(closes issue ASTERISK-11544)
Reported by: nizon
Patches:
     devstate-patch.txt uploaded by nizon (license 415)
       -- Updated to trunk, and tab completion added by me

........
r105477 | twilson | 2008-02-29 19:30:37 -0600 (Fri, 29 Feb 2008) | 6 lines

Asterisk, when parking can drop rights a caller when a parking timeout occurs.  Also, when doing built-in attended transfers, sometimes incorrectly passes rights from the transferrer to the transferee.  This patch tries to fixes the parking issue and lays some groundwork for later fixing the transfer issue.

(closes issue ASTERISK-11012)
Reported by: pliew
Tested by: otherwiseguy

........
r105479 | tilghman | 2008-02-29 20:03:51 -0600 (Fri, 29 Feb 2008) | 2 lines

Drop bad property

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=105480