Summary:	ASTERISK-10944: ENUMLOOKUP broken in 1.4.15
Reporter:	Chris Tracy (adiemus)	Labels:
Date Opened:	2007-12-01 14:39:26.000-0600	Date Closed:	2007-12-02 03:40:08.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Functions/func_enum
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) as-branch-1.4.patch
Description:	In 1.4.14, ENUMLOOKUP works as expected.  In 1.4.15, the lookup isn't ever actually performed. ****** ADDITIONAL INFORMATION ****** By inserting debugging output, I was able to determine that in: ast_get_enum (main/enum.c) line 465:    if (chan && ast_autoservice_start(chan) < 0)        return -1; this return is being taken.  'chan' has a valid value, but the call to ast_autoservice_start() fails.  As near as I can tell, this happens in: ast_autoservice_start (main/autoservice.c) line 154:   if (!as && (as = ast_calloc(1, sizeof(*as)))) { because 'as' isn't undefined, so the if fails and ast_autoservice_start ends up returning -1.  I'm not enough of a C programmer to determine where the issue actually is.  I would suspect it's in autoservice.c, as there were quite a few changes to autoservice between 1.4.14 and 1.4.15.  If you need any further information, please let me know.
Comments:	By: pj (pj) 2007-12-01 15:34:35.000-0600 it seems, that enumlookup in trunk is also broken. Asterisk SVN-group-sip-tcptls-r90416M-/trunk By: Dmitry Andrianov (dimas) 2007-12-01 17:07:08.000-0600 Can you please try attached patch? It should apply to both 1.4 and trunk. By: bjweeks (bjweeks) 2007-12-02 00:24:35.000-0600 I'm using trunk r90410 and with a clean install I couldn't do any enum lookups, they just failed. I applied the patch, it applied cleanly and fixed the problem. By: Digium Subversion (svnbot) 2007-12-02 03:31:44.000-0600 Repository: asterisk Revision: 90432 U   branches/1.4/main/autoservice.c ------------------------------------------------------------------------ r90432 | tilghman | 2007-12-02 03:31:43 -0600 (Sun, 02 Dec 2007) | 7 lines Clarify the return value on autoservice.  Specifically, if you started autoservice and autoservice was already on, it would erroneously return an error. Reported by: adiemus Patch by: dimas (Closes issue ASTERISK-10944) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-12-02 03:40:08.000-0600 Repository: asterisk Revision: 90433 _U  trunk/ U   trunk/main/autoservice.c ------------------------------------------------------------------------ r90433 | tilghman | 2007-12-02 03:40:07 -0600 (Sun, 02 Dec 2007) | 15 lines Merged revisions 90432 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r90432 | tilghman | 2007-12-02 03:34:23 -0600 (Sun, 02 Dec 2007) | 7 lines Clarify the return value on autoservice.  Specifically, if you started autoservice and autoservice was already on, it would erroneously return an error. Reported by: adiemus Patch by: dimas (Closes issue ASTERISK-10944) ........ ------------------------------------------------------------------------