Summary:	ASTERISK-10926: Better quota handling with IMAP storage
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2007-11-29 11:05:46.000-0600	Date Closed:	2007-12-21 14:15:10.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) imap_quotas.patch ( 1) imap_quotasv2.patch
Description:	This patch has 3 components: 1 - Refactor quota checking to a check_quota() method 2 - Add additional quota check for number of messages in IMAP mailbox (currently only IMAP quotas - disk usage - are checked with IMAP storage enabled) 3 - Add quota check when user logs in to their own mailbox, to inform them that their mailbox is over-quota (either in number of messages or IMAP quota)
Comments:	By: Mark Michelson (mmichelson) 2007-11-29 16:04:31.000-0600 This seems like a good (and much needed) patch. The only thing I don't like is the hard-coded word "INBOX" since a user may have a different folder specified (via the imapfolder voicemail.conf option). The problem is, it's not enough just to modify this one patch, since the mbox() function has "INBOX" hardcoded as well. I am going to add the project of removing the word "INBOX" from the IMAP code path to my queue and I will report back here once it has been taken care of. Once I have taken care of that, the only change needed for this patch will be to change the literal "INBOX" to imapfolder instead. By: Digium Subversion (svnbot) 2007-12-14 15:37:32.000-0600 Repository: asterisk Revision: 93094 U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r93094 | mmichelson | 2007-12-14 15:37:31 -0600 (Fri, 14 Dec 2007) | 5 lines Change places where the name "INBOX" was hardcoded to use the imapfolder setting from voicemail.conf instead. This commit will help to get issue ASTERISK-10926 moving towards commitment. ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=93094 By: Mark Michelson (mmichelson) 2007-12-14 15:41:11.000-0600 After realizing that I had let issue 11152 languish for a month (thanks for the prod selsky!) I went ahead and made the above commit to move "INBOX" out of the code path for IMAP voicemail in favor of the imapfolder option. I still have some time now, so I will make the few changes needed to the originally submitted patch and get it posted ASAP. Edit: I originally had written that I'd get the patch committed ASAP, but I realize that it is much more sensible just to get it posted first and make sure it actually works properly first. By: Mark Michelson (mmichelson) 2007-12-14 15:51:38.000-0600 imap_quotasv2 is ready for testing now. It only has a single word changed from the original posted patch, but due to commit number 93094, it should be ready to go. Please test to be sure I have not made any mistakes. By: Digium Subversion (svnbot) 2007-12-21 14:08:18.000-0600 Repository: asterisk Revision: 94540 U   branches/1.4/apps/app_voicemail.c ------------------------------------------------------------------------ r94540 | mmichelson | 2007-12-21 14:08:18 -0600 (Fri, 21 Dec 2007) | 8 lines Better quota support for using IMAP storage voicemail (closes issue ASTERISK-10926, reported by jaroth) (closes issue ASTERISK-10678, reported by selsky) Patch provided by jaroth ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94540 By: Digium Subversion (svnbot) 2007-12-21 14:15:10.000-0600 Repository: asterisk Revision: 94542 _U  trunk/ U   trunk/apps/app_voicemail.c ------------------------------------------------------------------------ r94542 | mmichelson | 2007-12-21 14:15:10 -0600 (Fri, 21 Dec 2007) | 16 lines Merged revisions 94540 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r94540 | mmichelson | 2007-12-21 14:11:34 -0600 (Fri, 21 Dec 2007) | 8 lines Better quota support for using IMAP storage voicemail (closes issue ASTERISK-10926, reported by jaroth) (closes issue ASTERISK-10678, reported by selsky) Patch provided by jaroth ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=94542