[Home]

Summary:ASTERISK-10925: [patch] Move loading users from authenticate() to __init_manager()
Reporter:Yuri (ys)Labels:
Date Opened:2007-11-29 09:13:58.000-0600Date Closed:2007-12-16 07:32:03.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) trunk90150_manager.c.diff
( 1) trunk93163_manager_reload.c.diff
Description:I try to move users loading process from authenticate() to __init_manager() function for better performance.

Now, if AMI user try to authenticate, manager interface load user information from users.conf and manager.conf file. I try to move this into init process, and now user information loaded or reloaded, if module loaded or reloaded  correspondingly.
Comments:By: Olle Johansson (oej) 2007-12-16 03:51:44.000-0600

Hmmm. I've seen this in another bug report too. Let's see if we can find that and merge the efforts.
By: Olle Johansson (oej) 2007-12-16 04:00:00.000-0600

Please check bug 10961!
By: Olle Johansson (oej) 2007-12-16 04:51:35.000-0600

Do we need a manager reload cli command for reloading the configuration now, when you add or remove users?
By: Yuri (ys) 2007-12-16 06:17:18.000-0600

Hmm. Good question.

Now "reload manager" are deprecated.
I add simple "manager reload" cli command.
Patch uploaded.
By: Digium Subversion (svnbot) 2007-12-16 07:29:42.000-0600

Repository: asterisk
Revision: 93165

U   trunk/CHANGES
U   trunk/main/manager.c

------------------------------------------------------------------------
r93165 | oej | 2007-12-16 07:29:41 -0600 (Sun, 16 Dec 2007) | 11 lines

Change manager so that registered accounts are stored in memory. This opens for a
manager realtime implementation.

If you change accounts in manager.conf, you now need to reload to activate the
changes (deletions, additions). This was not the case with 1.4.

Reported by: ys
Patches:
     trunk93163_manager_reload.c.diff uploaded by ys (license 281)
(closes issue ASTERISK-10925)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=93165
By: Digium Subversion (svnbot) 2007-12-16 07:32:03.000-0600

Repository: asterisk
Revision: 93166

U   trunk/CHANGES
U   trunk/main/manager.c

------------------------------------------------------------------------
r93166 | oej | 2007-12-16 07:32:02 -0600 (Sun, 16 Dec 2007) | 8 lines

Adding a new CLI command for "manager reload", which is important now that
you need to reload after changes. Thanks YS.

Reported by: ys
Patches:
     trunk93163_manager_reload.c.diff uploaded by ys (license 281)
(related to issue ASTERISK-10925)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=93166