[Home]

Summary:ASTERISK-10922: [patch] Default penalty for member added using QueueAdd
Reporter:Tomás Laureano Peralta Tormey (laureano)Labels:
Date Opened:2007-11-28 20:51:14.000-0600Date Closed:2007-11-29 13:36:55.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_queue.c.patch
Description:When sending to the manager an action to add a member in a queue with a penalty lower than 0, the member will be added with this invalid penalty.
This patch checks that the penalty is greater than cero, if not, set the penalty to 0; as other functions do when adding a member.

Disclaimer on file.

****** STEPS TO REPRODUCE ******

Log in to the manager. Try to add a member with an invalid penalty, by sending to the manager:

<- Action: QueueAdd
<- Queue: markq
<- Interface: SIP/100
<- Penalty: -1

Response will be:

-> Response: Success
-> Message: Added interface to queue

-> Event: QueueMemberAdded
-> Privilege: agent,all
-> Queue: markq
-> Location: SIP/100
-> MemberName: SIP/100
-> Membership: dynamic
-> Penalty: -1
-> CallsTaken: 0
-> LastCall: 0
-> Status: 4
-> Paused: 0

CLI output:
markq        has 0 calls (max unlimited) in 'ringall' strategy (0s holdtime), W:0, C:0, A:0, SL:0.0% within 60s
  Members:
     SIP/100 with penalty -1 (dynamic) (Invalid) has taken no calls yet
  No Callers

****** ADDITIONAL INFORMATION ******

The SIP devices is invalid because isn't registered.
Comments:By: Digium Subversion (svnbot) 2007-11-29 13:36:03.000-0600

Repository: asterisk
Revision: 90163

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r90163 | mmichelson | 2007-11-29 13:36:02 -0600 (Thu, 29 Nov 2007) | 6 lines

This patch handles the case where a queue member with a negative penalty is added
via the manager. If a negative value is submitted for a member penalty, we set it to 0.

(closes issue ASTERISK-10922, reported and patched by Laureano)


------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-29 13:36:55.000-0600

Repository: asterisk
Revision: 90164

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r90164 | mmichelson | 2007-11-29 13:36:55 -0600 (Thu, 29 Nov 2007) | 14 lines

Merged revisions 90163 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90163 | mmichelson | 2007-11-29 13:38:39 -0600 (Thu, 29 Nov 2007) | 6 lines

This patch handles the case where a queue member with a negative penalty is added
via the manager. If a negative value is submitted for a member penalty, we set it to 0.

(closes issue ASTERISK-10922, reported and patched by Laureano)


........

------------------------------------------------------------------------