[Home]

Summary:ASTERISK-10912: Variable identifier not compatible with C++
Reporter:chewbacca (chewbacca)Labels:
Date Opened:2007-11-28 12:13:02.000-0600Date Closed:2007-11-29 17:48:13.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) private.90151.diff
Description:Asterisk 1.4.14, include/asterisk/file.h, line 135

void *private; /* pointer to private buffer */

this mess up all c++ projects that includes file.h
Comments:By: Jason Parker (jparker) 2007-11-28 13:37:53.000-0600

Is the problem than "private" is a reserved word in C++?

You weren't clear on how it is not compatible.
By: Andrey S Pankov (casper) 2007-11-29 10:26:22.000-0600

Please try my patch...
By: Digium Subversion (svnbot) 2007-11-29 11:27:24.000-0600

Repository: asterisk
Revision: 90155

U   branches/1.4/formats/format_g726.c
U   branches/1.4/formats/format_h263.c
U   branches/1.4/formats/format_h264.c
U   branches/1.4/formats/format_ogg_vorbis.c
U   branches/1.4/formats/format_pcm.c
U   branches/1.4/formats/format_wav.c
U   branches/1.4/formats/format_wav_gsm.c
U   branches/1.4/include/asterisk/file.h
U   branches/1.4/main/file.c

------------------------------------------------------------------------
r90155 | tilghman | 2007-11-29 11:27:23 -0600 (Thu, 29 Nov 2007) | 5 lines

Use of "private" as a field name in a header file messes with C++ projects
Reported by: chewbacca
Patch by: casper
(Closes issue ASTERISK-10912)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-29 11:48:09.000-0600

Repository: asterisk
Revision: 90158

_U  trunk/
U   trunk/formats/format_g726.c
U   trunk/formats/format_h263.c
U   trunk/formats/format_h264.c
U   trunk/formats/format_ogg_vorbis.c
U   trunk/formats/format_pcm.c
U   trunk/formats/format_wav.c
U   trunk/formats/format_wav_gsm.c
U   trunk/include/asterisk/mod_format.h
U   trunk/main/file.c

------------------------------------------------------------------------
r90158 | tilghman | 2007-11-29 11:48:08 -0600 (Thu, 29 Nov 2007) | 13 lines

Merged revisions 90155 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90155 | tilghman | 2007-11-29 11:29:59 -0600 (Thu, 29 Nov 2007) | 5 lines

Use of "private" as a field name in a header file messes with C++ projects
Reported by: chewbacca
Patch by: casper
(Closes issue ASTERISK-10912)

........

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-29 17:45:19.000-0600

Repository: asterisk-addons
Revision: 490

U   branches/1.4/format_mp3/format_mp3.c

------------------------------------------------------------------------
r490 | tilghman | 2007-11-29 17:45:18 -0600 (Thu, 29 Nov 2007) | 2 lines

Track API change (Closes issue ASTERISK-10912)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-29 17:48:13.000-0600

Repository: asterisk-addons
Revision: 491

_U  trunk/
U   trunk/format_mp3/format_mp3.c

------------------------------------------------------------------------
r491 | tilghman | 2007-11-29 17:48:12 -0600 (Thu, 29 Nov 2007) | 10 lines

Merged revisions 490 via svnmerge from
https://origsvn.digium.com/svn/asterisk-addons/branches/1.4

........
r490 | tilghman | 2007-11-29 17:47:53 -0600 (Thu, 29 Nov 2007) | 2 lines

Track API change (Closes issue ASTERISK-10912)

........

------------------------------------------------------------------------