[Home]

Summary:ASTERISK-10898: Loading of res_config_pgsql will crash on dbhost/dbsock combination
Reporter:P. Christeas (xrg)Labels:
Date Opened:2007-11-27 11:56:16.000-0600Date Closed:2007-12-06 14:49:57.000-0600
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Resources/res_config_pgsql
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:A trivial logic error exists wrt. res_pgsql.conf parsing:
When dbhost is not set, conditional will try to copy "s" which may have been NULL (when dbport=NULL)!





****** ADDITIONAL INFORMATION ******

<patch deleted for licensing reasons>

Comments:By: Mark Michelson (mmichelson) 2007-11-27 17:33:37.000-0600

As trivial a change as this is, we cannot accept code contributions unless you have signed the license agreement.

Also, please upload patches as attachments as per the bug guidelines. Thanks!
By: P. Christeas (xrg) 2007-11-28 01:44:07.000-0600

You may contact me. There is some minor objections I have with that license.
By: Digium Subversion (svnbot) 2007-12-03 17:21:11.000-0600

Repository: asterisk
Revision: 90736

U   branches/1.4/res/res_config_pgsql.c

------------------------------------------------------------------------
r90736 | tilghman | 2007-12-03 17:21:11 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue ASTERISK-10898)

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-12-03 17:27:14.000-0600

Repository: asterisk
Revision: 90737

_U  trunk/
U   trunk/res/res_config_pgsql.c

------------------------------------------------------------------------
r90737 | tilghman | 2007-12-03 17:27:13 -0600 (Mon, 03 Dec 2007) | 13 lines

Merged revisions 90736 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90736 | tilghman | 2007-12-03 17:23:55 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue ASTERISK-10898)

........

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-12-06 14:49:57.000-0600

Repository: asterisk
Revision: 91561

_U  trunk/
U   trunk/cdr/cdr_pgsql.c

------------------------------------------------------------------------
r91561 | tilghman | 2007-12-06 14:49:57 -0600 (Thu, 06 Dec 2007) | 27 lines

Merged revisions 90166,90736,90753 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90166 | tilghman | 2007-11-29 13:48:10 -0600 (Thu, 29 Nov 2007) | 3 lines

Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping
(Fixes AST-2007-026)

........
r90736 | tilghman | 2007-12-03 17:23:55 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue ASTERISK-10898)

........
r90753 | tilghman | 2007-12-03 17:50:51 -0600 (Mon, 03 Dec 2007) | 5 lines

Solaris requires the inclusion of sys/loadavg.h for getloadavg().
Reported by: snuffy
Patch by: snuffy,tilghman
(Closes issue ASTERISK-10941)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=91561