Summary:	ASTERISK-10873: [patch] Error compiling chan_h323 with DEBUG_THREADS
Reporter:	Tomás Laureano Peralta Tormey (laureano)	Labels:
Date Opened:	2007-11-23 23:02:31.000-0600	Date Closed:	2007-11-24 07:59:05.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_h323
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_h323.c.patch
Description:	Trying to compile chan_h323 with DEBUG_THREADS compiler flag activated produce the following error:   [CC] chan_h323.c -> chan_h323.o chan_h323.c: In function "cleanup_connectionâ: chan_h323.c:2361: error: "struct ast_channel" has no member named "lock" chan_h323.c:2361: error: "struct ast_channel" has no member named "lock" chan_h323.c:2361: error: "struct ast_channel" has no member named "lock" chan_h323.c:2361: error: "struct ast_channel" has no member named "lock" chan_h323.c:2361: error: "struct ast_channel" has no member named "lock" make[1]: *** [chan_h323.o] Error 1 make: *** [channels] Error 2 chan_h323 references to the lock structure, which has been renamed to lock_dont_use. I think that the options are: 1) Delete the references to ast_mutex primitives and leave only the debugging message on line number 2361 to avoid accesing the ast_mutex primitives (as suggested on revision 89293). 2) Apply the uploaded patch. All suggestions are welcome. Disclaimer on file. ****** STEPS TO REPRODUCE ****** Run "make menuselect" and enable "DEBUG_THREADS" on the submenu "Compiler Flags" with chan_h323 enabled. Run "make". ****** ADDITIONAL INFORMATION ****** PwLib version:1.10.0 OpenH323 version: 1.18.0
Comments:	By: Digium Subversion (svnbot) 2007-11-24 07:55:20.000-0600 Repository: asterisk Revision: 89543 U   trunk/channels/chan_h323.c ------------------------------------------------------------------------ r89543 | rizzo | 2007-11-24 07:55:19 -0600 (Sat, 24 Nov 2007) | 7 lines remove a DEBUG_THREADS message that accesses private lock fields. If needed, the code to extract this information should be implemented in some generic header or library and the function called here. (closed bug ASTERISK-10873) ------------------------------------------------------------------------ By: Luigi Rizzo (rizzo) 2007-11-24 07:56:12.000-0600 thanks for the report. For the time being i simply removed the extra information, and put a note on how it should be put back in.