Summary:	ASTERISK-10868: filestream is not closed before executing commands
Reporter:	reformed (reformed)	Labels:
Date Opened:	2007-11-23 07:18:06.000-0600	Date Closed:	2007-11-26 11:21:00.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_mixmonitor
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) mixmonitor.patch
Description:	mixmonitor_thread() closes filestream after it executes [command] If cache_record_files option used, recorded files will always result in empty files. I suggest moving ast_closestream if stament above if(mixmonitor->post_process) I have tested this on our production machine and everything behaves as expected after the change. All * versions are affected by this.
Comments:	By: reformed (reformed) 2007-11-23 18:23:37.000-0600 Clarification: When mixmonitor executes user supplied command the stream is not closed so asterisk has not copied the file from /tmp to the final destination resulting in empty files. After [command] is finished the stream is closed and the file is copied from /tmp to the final destination. By: reformed (reformed) 2007-11-24 07:33:11.000-0600 Patch attached. I have faxes the license agreement to Digium long long time ago. By: snuffy (snuffy) 2007-11-25 15:18:09.000-0600 reformed.. you must sign the web disclaimer now, the fax ones are invalidated By: reformed (reformed) 2007-11-25 15:21:02.000-0600 Signed already. :) Status is License Pending. By: Digium Subversion (svnbot) 2007-11-26 11:18:31.000-0600 Repository: asterisk Revision: 89587 U   branches/1.4/apps/app_mixmonitor.c ------------------------------------------------------------------------ r89587 | file | 2007-11-26 11:18:30 -0600 (Mon, 26 Nov 2007) | 6 lines Close the audio file before sending it to the post processing application. (closes issue ASTERISK-10868) Reported by: reformed Patches:      mixmonitor.patch uploaded by reformed (license 330) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-11-26 11:21:00.000-0600 Repository: asterisk Revision: 89589 _U  trunk/ U   trunk/apps/app_mixmonitor.c ------------------------------------------------------------------------ r89589 | file | 2007-11-26 11:20:59 -0600 (Mon, 26 Nov 2007) | 14 lines Merged revisions 89587 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89587 | file | 2007-11-26 13:20:58 -0400 (Mon, 26 Nov 2007) | 6 lines Close the audio file before sending it to the post processing application. (closes issue ASTERISK-10868) Reported by: reformed Patches:      mixmonitor.patch uploaded by reformed (license 330) ........ ------------------------------------------------------------------------