Summary:ASTERISK-10861: [patch] Deprecate SIPPEER()/IAXPEER() and move functionality into CHANNEL()
Reporter:Leif Madsen (lmadsen)Labels:
Date Opened:2007-11-22 09:00:06.000-0600Date Closed:2008-02-06 04:14:46.000-0600
Versions:Frequency of
Environment:Attachments:( 0) __20071125_sippeer_to_channel_patch.txt
( 1) __20071128_sippeer_and_iaxpeer_to_channel_patch.txt
( 2) patch_sippeer_to_channel.patch.txt
( 3) patch_sippeer_to_channel.patch-2.txt
Description:Here is a patch that I worked on while on the train in order to get my feet wet with some C coding.

I'm not entirely sure I like the sip_peerinfo item name... maybe that should just be sippeer?

I used the same format for the IAX section:  iax_peerinfo
Comments:By: Dmitry Andrianov (dimas) 2007-11-22 09:14:02.000-0600

I'm not familar with the Asterisk release process, but doesn't "deprecate something" also mean that some documentation like UPGRADE.txt/README.txt should be updated as well?

And I know, it is personal preferrences but it would be easier to check that all types properly described in description text if they appear in the acf_channel_read and in the channel_function in the same order...

By: Leif Madsen (lmadsen) 2007-11-22 09:17:02.000-0600

That makes sense. I'll update those two text files.

I guess the text wasn't originally in the same order as the code, as it was generally a copy/paste of that part of the code. I'll reorder it though if that is desired.

By: Leif Madsen (lmadsen) 2007-11-22 09:47:39.000-0600

Changed the UPGRADE.txt (and fixed the line above that had an incorrect CLI command).

Also added a LOG_WARNING when you specify an invalid 2nd argument.

By: Leif Madsen (lmadsen) 2007-11-26 10:39:06.000-0600

__20071125_sippeer_to_channel_patch.txt moves the find_peer stuff inside the if() block so that it doesn't get called unless you're looking for peer info data

By: Leif Madsen (lmadsen) 2007-11-28 13:45:26.000-0600

Added a new patch which contains both SIPPEER() and IAXPEER() functionality in CHANNEL()

By: Olle Johansson (oej) 2007-12-06 04:01:51.000-0600

This doesn't make sense to me. I would propose a DEVICE() function to check devices. CHANNEL is for active calls, and peers/users/lines may not be active in the current call.

By: Olle Johansson (oej) 2007-12-10 07:43:51.000-0600

Any comments, Leif?

By: Leif Madsen (lmadsen) 2007-12-10 10:11:06.000-0600

Hey Olle,

Sorry, I didn't see the first response.

Yes, I think that makes sense to me. I never really did like the way this worked out (it's the right format, but fugly as heck! :))

DEVICE() seems to make sense to me.

By: jmls (jmls) 2008-02-06 04:11:25.000-0600

so, can we close this report ?