Summary: | ASTERISK-10849: Hook-Flash behaviour results in echo-cancellation disabled on channel during call. | ||
Reporter: | rebuild (rebuild) | Labels: | |
Date Opened: | 2007-11-21 06:39:09.000-0600 | Date Closed: | 2008-03-10 15:25:27 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_zap |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | With asterisk 1.4.11, during a standard call, 'zap show channel 1' reports echo cancellation as 'ON'. With call waiting, accepting the second call keeps echo cancellation as expected. When on a single call, pressing hook-flash to get a second dial tone turns off echo cancellation. If you successfully dial another number, echo cancellation is renegotiated, and is set correctly for that call. Hanging up, will result in the call on hold 'calling back' the hand set. When you pick up the hand set, you hear a screech, and 'zap show channel 1' shows echo cancellation as disabled, and you hear echo during the call after resuming. Upgrading to 1.4.12/13/14 changed this behaviour slightly. Now echo cancellation is disabled by hook-flash, and remains disabled, even when hook-flash is used to resume the call on hold. ****** ADDITIONAL INFORMATION ****** ZAP Hardware: TDM400P 3FXS 1FXO, nothing plugged into FXO, all calls are VOIP. Reproducible Sequence: Call *43 (echo test) 'zap show channel 1' shows echo cancellation ON Press Hook Flash, listen for dial tone. Hang-Up. Listen for callback from existing 'on hold' call. Pickup phone. Resume 'echo test'. Note added echo effects, and possible audio screech.. 'zap show channel 1' shows echo cancellation OFF | ||
Comments: | By: rebuild (rebuild) 2007-11-21 06:41:35.000-0600 NOTE. If you vary the above sequence. 1) call echo test 2) hook flash 3) listen for dial tone. 4) zap show channel 1 shows echo cancellation OFF. 5) press hook flash 6) resume call 7) zap show channel 1 shows echo cancellation ON. This applies to 1.4.11 only. Asterisk 1.4.12 and above show echo cancellation OFF at step 7 By: Digium Subversion (svnbot) 2008-03-10 15:23:22 Repository: asterisk Revision: 107173 U branches/1.4/channels/chan_zap.c ------------------------------------------------------------------------ r107173 | qwell | 2008-03-10 15:23:21 -0500 (Mon, 10 Mar 2008) | 5 lines Make sure to reenable echo can after a "failed" (canceled, etc) three-way call. (closes issue ASTERISK-10849) Reported by: rebuild ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107173 By: Digium Subversion (svnbot) 2008-03-10 15:24:44 Repository: asterisk Revision: 107177 _U trunk/ U trunk/channels/chan_zap.c ------------------------------------------------------------------------ r107177 | qwell | 2008-03-10 15:24:44 -0500 (Mon, 10 Mar 2008) | 13 lines Merged revisions 107173 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r107173 | qwell | 2008-03-10 15:27:08 -0500 (Mon, 10 Mar 2008) | 5 lines Make sure to reenable echo can after a "failed" (canceled, etc) three-way call. (closes issue ASTERISK-10849) Reported by: rebuild ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107177 By: Digium Subversion (svnbot) 2008-03-10 15:25:27 Repository: asterisk Revision: 107180 _U branches/1.6.0/ U branches/1.6.0/channels/chan_zap.c ------------------------------------------------------------------------ r107180 | qwell | 2008-03-10 15:25:26 -0500 (Mon, 10 Mar 2008) | 21 lines Merged revisions 107177 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r107177 | qwell | 2008-03-10 15:28:33 -0500 (Mon, 10 Mar 2008) | 13 lines Merged revisions 107173 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r107173 | qwell | 2008-03-10 15:27:08 -0500 (Mon, 10 Mar 2008) | 5 lines Make sure to reenable echo can after a "failed" (canceled, etc) three-way call. (closes issue ASTERISK-10849) Reported by: rebuild ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107180 |