[Home]

Summary:ASTERISK-10838: Errors in queues-with-callback-members.txt
Reporter:Nicolas Ross (rossnick)Labels:
Date Opened:2007-11-20 08:50:25.000-0600Date Closed:2007-11-20 09:28:31.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In doc/queues-with-callback-members.txt, there are 2 errors in switch case.

Line 352, there is no break; statement inside each of the cases
Line 369, there is no break; statement inside each of the cases

****** ADDITIONAL INFORMATION ******

Should have read :

macro queue-success()
{
       if( ${queue-announce-success} > 0 )
       {
               switch(${MACRO_EXTEN:0:1})
               {
               case I:
                       Playback(agent-loginok);
                       Hangup();
                       break;
               case O:
                       Playback(agent-loggedoff);
                       Hangup();
                       break;
               }
       }
}

macro queue-addremove(queuename,penalty)
{
       switch(${MACRO_EXTEN:0:1})
       {
       case I:  // Login
               {
               AddQueueMember(${queuename},Local/${MACRO_EXTEN:1}@agents,${penalty});
               }
       case O:  // Logout
               {
               RemoveQueueMember(${queuename},Local/${MACRO_EXTEN:1}@agents);
               break;
               }
       case P:  // Pause
               {
               PauseQueueMember(${queuename},Local/${MACRO_EXTEN:1}@agents);
               break;
               }
       case U:  // Unpause
               {
               UnpauseQueueMember(${queuename},Local/${MACRO_EXTEN:1}@agents);
               break;
               }
       default: // Invalid
               {
               Playback(invalid);
               break;
               }
       }
}
Comments:By: Digium Subversion (svnbot) 2007-11-20 09:19:50.000-0600

Repository: asterisk
Revision: 89450

U   branches/1.4/doc/queues-with-callback-members.txt

------------------------------------------------------------------------
r89450 | murf | 2007-11-20 09:19:49 -0600 (Tue, 20 Nov 2007) | 1 line

closes issue ASTERISK-10838; break statements missing in switch cases.
------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-20 09:28:31.000-0600

Repository: asterisk
Revision: 89451

_U  trunk/
U   trunk/doc/tex/queues-with-callback-members.tex

------------------------------------------------------------------------
r89451 | murf | 2007-11-20 09:28:29 -0600 (Tue, 20 Nov 2007) | 9 lines

Merged revisions 89450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89450 | murf | 2007-11-20 08:22:08 -0700 (Tue, 20 Nov 2007) | 1 line

closes issue ASTERISK-10838; break statements missing in switch cases.
........

------------------------------------------------------------------------