Summary:ASTERISK-10806: commit 8938 should be reverted
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2007-11-19 07:29:45.000-0600Date Closed:2007-11-20 16:27:35.000-0600
Versions:Frequency of
Description:Commit 89338 by rizzo "logger.h does not need options.h".

Really? ast_debug defined in logger.h depends on option_debug so if I only onclude "logger.h" without "option.h" I get cmpilation errors
Comments:By: Dmitry Andrianov (dimas) 2007-11-19 07:37:13.000-0600

I'm probably wrong about "major" severity since asterisk itself compiles fine. Sorry about that.

By: Joshua C. Colp (jcolp) 2007-11-19 07:46:21.000-0600

Please reply to the commit to the -commits list so this issue is brought up on the -dev list and can be discussed by rizzo and others.

By: Dmitry Andrianov (dimas) 2007-11-20 16:10:05.000-0600

file, I emailed to -dev but it doesn't seem my email got any attention. I believe this one is an issue and it is different from similarly looking stuff other people submitted because it is not caused by missing #include <asterisk.h>

Can you please leave the issue open (otherwise it will be just lost) and assign it to rizzo to let him take care or explain what is "the new way" of including logger.

By: Joshua C. Colp (jcolp) 2007-11-20 16:27:35.000-0600

rizzo saw this and reverted his change in revision 89412.