Summary:	ASTERISK-10780: [patch] HOLD notification for Polycom phones
Reporter:	Russell Bryant (russell)	Labels:
Date Opened:	2007-11-15 13:55:01.000-0600	Date Closed:	2008-03-13 16:03:32
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Subscriptions
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) notify_hold.rev1.txt
Description:	We added support for notifying HOLD status back when I was writing the SLA code.  However, this only worked for some phones.  It never did work for Polycom phones.  Polycom phones use the application/xpidf+xml format for the XML format we send the state information in. This change makes HOLD notification work for polycom phones. However, this change will also slightly affect the format sent in application/pidf+xml format.  According to a comment in the code, eyebeam supports this format.  I'm not sure if hold notification worked with eyebeam before, but I wanted to check to see if this patch had any effect on that before committing.
Comments:	By: Russell Bryant (russell) 2007-11-15 13:56:37.000-0600 Hey oej, I posted this here so that you could take a look at it.  I hope you don't mind.  :)  Thanks! By: Olle Johansson (oej) 2007-11-18 11:50:21.000-0600 Ok, I'll take a look :-) By: Olle Johansson (oej) 2007-11-18 11:52:16.000-0600 I don't think "CLOSED" is the right thing to do. Isn't there any documentation on the different states that Polycom supports? This format doesn't have any explicit hold states, so we just have to find what works best for SIMPLE clients as well as the phones that try to show something based on the SIMPLE states. By: Russell Bryant (russell) 2007-11-18 19:50:33.000-0600 I will try to look around for some documentation. You're right, there doesn't appear to be an official way to indicate hold in this format.  I was just poking at things until the light started blinking the way that I want it to.  :)  I'm not sure how other clients would react to the same change. We could always make this polycom specific, but I guess I should try to read more about what these states are supposed to mean ... By: Olle Johansson (oej) 2007-11-19 01:27:06.000-0600 Well, this is a format intended for personal status in IM clients, jabber-like, not for lamps or call states. I kind of made it work for call states by adding the texts, which is a hack. In presence, there's really no need for "hold" - maybe only in the meaning "standing by for an airline ticket, wish me luck" or "in queue for the loo, might disappear quicker than you expect"... :-) By: Digium Subversion (svnbot) 2008-03-13 16:02:43 Repository: asterisk Revision: 108530 U   branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r108530 | russell | 2008-03-13 16:02:40 -0500 (Thu, 13 Mar 2008) | 10 lines Make a tweak that gets the LEDs on polycom phones to blink when an extension that has been subscribed to goes on hold.  Otherwise, they just stay on like it does when an extension is in use. (closes issue ASTERISK-10780) Reported by: russell Patches:      notify_hold.rev1.txt uploaded by russell (license 2) Tested by: russell ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=108530 By: Digium Subversion (svnbot) 2008-03-13 16:03:12 Repository: asterisk Revision: 108531 _U  trunk/ U   trunk/channels/chan_sip.c ------------------------------------------------------------------------ r108531 | russell | 2008-03-13 16:03:06 -0500 (Thu, 13 Mar 2008) | 18 lines Merged revisions 108530 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r108530 | russell | 2008-03-13 16:06:33 -0500 (Thu, 13 Mar 2008) | 10 lines Make a tweak that gets the LEDs on polycom phones to blink when an extension that has been subscribed to goes on hold.  Otherwise, they just stay on like it does when an extension is in use. (closes issue ASTERISK-10780) Reported by: russell Patches:      notify_hold.rev1.txt uploaded by russell (license 2) Tested by: russell ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=108531 By: Digium Subversion (svnbot) 2008-03-13 16:03:32 Repository: asterisk Revision: 108532 _U  branches/1.6.0/ U   branches/1.6.0/channels/chan_sip.c ------------------------------------------------------------------------ r108532 | russell | 2008-03-13 16:03:24 -0500 (Thu, 13 Mar 2008) | 26 lines Merged revisions 108531 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r108531 | russell | 2008-03-13 16:06:52 -0500 (Thu, 13 Mar 2008) | 18 lines Merged revisions 108530 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r108530 | russell | 2008-03-13 16:06:33 -0500 (Thu, 13 Mar 2008) | 10 lines Make a tweak that gets the LEDs on polycom phones to blink when an extension that has been subscribed to goes on hold.  Otherwise, they just stay on like it does when an extension is in use. (closes issue ASTERISK-10780) Reported by: russell Patches:      notify_hold.rev1.txt uploaded by russell (license 2) Tested by: russell ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=108532