[Home]

Summary:ASTERISK-10778: [patch] chan_h323 with H323Plus for TRUNK (SVN rev. 89183)
Reporter:Vlasis Hatzistavrou (vhatz)Labels:
Date Opened:2007-11-15 11:46:12.000-0600Date Closed:2009-03-17 15:54:00
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_h323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast_h323.cxx.patch
( 1) ast_h323.h.patch
( 2) asterisk_1.6.01.code.tgz
( 3) asterisk-1.6.0.6-h323plus.patch
( 4) asterisk-trunk-H323Plus.tar
( 5) compat_h323.cxx.patch
( 6) conf_n_log.tgz
( 7) h323p-14-r108926.diff
( 8) h323p-leaks.txt
( 9) INSTALL.h323plus
Description:This is a modification to the trunk version of SVN rev. 89183 chan_h32. This modification enables chan_h323 to compile and use the latest H323Plus library instead of the OpenH323 library.

****** ADDITIONAL INFORMATION ******

Information for installation can be found in the channels/h323/INSTALL.h323plus file.
Comments:By: Eliel Sardanons (eliel) 2007-12-12 09:49:41.000-0600

You should upload this as a patch (svn diff [see bug guidelines]) and not just upload the complete files.

Thanks!
By: Vlasis Hatzistavrou (vhatz) 2007-12-20 09:37:38.000-0600

The following patches are the code additions for having the trunk version of SVN rev. 89183 compile with the H323Plus library.

Please read the instructions in INSTALL.h323plus.
By: Sergey Tamkovich (sergee) 2008-03-16 04:10:31

H323Plus seems to me as reanmed copy of OpenH323, at least it has the same leaks :) (check attached file).

Also i made normal patch for asterisk 1.4 for those who would like to try h323plus instead of OpenH323, although i don't see any reason for such exchange.
By: Vlasis Hatzistavrou (vhatz) 2008-03-21 13:32:19

There is good reason for using H323Plus, as OpenH323 is not developed any longer...
By: Sergey Tamkovich (sergee) 2008-03-23 10:57:37

I don't see any development in h323plus either, as i told, it is more like a renamed copy, it has same leeks, may be it would be better in future, but for now there are no benefits...
By: Leif Madsen (lmadsen) 2008-10-07 13:14:58

I'm suspending this for now as it seems there is a lack of interest in using the h323plus library to build against.

Please re-open should someone have a way to move this forward. Thanks!
By: Leif Madsen (lmadsen) 2008-11-24 17:24:37.000-0600

I am going to reopen this issue as it does appear H323Plus is mildly active. However, there are some stipulations to this bug continuing to remain open:

 1) It has to be backwards compatible. Nothing else is acceptable.
 2) Someone has to get feedback/testing for this patch, and keep the momentum moving forward. This issue can't just sit open for 9 months again.


I will give this issue a couple of weeks to see some sort of movement/comments that indicate this issue may actually get somewhere. Otherwise, we will need to suspend it again, and when someone can take up the cause to move this forward, we can reopen.

Lets hope someone takes it up right now though, and moves the issue to fruition!
By: Jason Parker (jparker) 2008-11-24 17:31:06.000-0600

vhatz: I would suggest posting to the asterisk-dev mailing list, to see if you can get some feedback/testing.
By: Vlasis Hatzistavrou (vhatz) 2008-11-25 04:43:48.000-0600

blitzrage: I am not entirely sure what you mean by backwards compatible. I posted this back then in the trunk version so that chan_h323 could switch to H323Plus in the upcoming 1.6 version. There were very little source code changes in chan_h323 and the h323.conf file remained the same.

Unless, however, you refer to something else and I'm completely missing the point.

qwell: I'd be happy to post to the mailing list, but I don't think that anyone would want to try & test SVN rev. 89183 now that v1.6 is out. However, I have made extensive testing on my own in production environment, and chan_h323 with H323Plus was at least as stable as chan_h323 with OpenH323. We've been using it for more than a year now on 1.4.x version.
By: Jason Parker (jparker) 2008-11-25 10:34:27.000-0600

By backwards compatible, I mean keep compatibility with the "standard" OpenH323.

I noticed there were what looked like API changes, and that concerns me a great deal.
By: Vlasis Hatzistavrou (vhatz) 2008-11-25 12:21:26.000-0600

There is no OpenH323 anymore. OpenH323 has moved into OPAL which is a lot more different.

The source code changes to adapt chan_h323 to H323Plus were very minimal, however. It was just as if one had to adapt chan_h323 to a slightly newer version of OpenH323.

In any case, chan_h323 required very specific OpenH323 versions to work with, sometimes it would not compile with older versions. So I don't understand why the newer chan_h323 cannot specify which exact H323Plus versions it needs...
By: cclemence (cclemama) 2008-12-04 14:59:52.000-0600

I needed to connect to our Avaya switch using h323 and found this post. I am running on FC10 using the most current version of asterisk (asterisk-1.6.0.1) and the latest versions of h323plus code (h323plus-v1_20_2 & ptlib-v2_0_1-4). Based upon the notes, I thought that the 1.6 code would compile without any issues. It would not. So I manually applied the pvhatz patches to the 1.6 code and got everything to compile. I was very pleased with how easy it was to get the h323 connection working with our Avaya switch. However, after more testing I think I found an issue.

When using a call file (i.e. autodial), control is passed on to the context/extension/ before the outgoing h323 call is answered. This behavior does not happen when I outbound dial a Sip, IAX2, or Zap channel.

I am new to the asterisk code and voip protocols, but I am willing to learn. I also have a system that we can use to test with. I have uploaded my changed source code, config files, and logs. Can one of you guys help direct me?
By: Leif Madsen (lmadsen) 2008-12-12 11:28:10.000-0600

cclemama: what you are reporting is really a separate issue from this one, which means you will need to open a separate bug report to track it. Thanks!
By: Leif Madsen (lmadsen) 2008-12-12 11:29:41.000-0600

Marking as confirmed since it appears we actually have someone who reports this patch worked for them.
By: Leif Madsen (lmadsen) 2008-12-12 11:37:21.000-0600

vhatz: the problem is that we can't stop supporting existing users who are using openh323, which is why it needs to be backwards compatible and support both libraries.
By: Sergey Tamkovich (sergee) 2008-12-15 07:24:32.000-0600

> the problem is that we can't stop supporting existing users who are using openh323, which is why it needs to be backwards compatible and support both libraries.


This is exactly what I have in mind. I don't mind if anybody will add support for h323plus as an option for chan_h323. I mind against replacement of openh323 1.18.0 - with anything else, at least in minor releases. Since oh323 1.18.0 completely satisfies me - I don't want to make any (potentially dangerous) movements.
By: Vlasis Hatzistavrou (vhatz) 2008-12-15 08:28:36.000-0600

Does anyone object that chan_h323 does not support OpenH323 versions older than 1.18.0?

Would there be any problem if H323Plus was named OpenH323 v2.1.0 and the developer of chan_h323 specified that it needed only the v2.1.0 OpenH323 version and not an older one? Would anyone object to that?

I think the answer would be "No" to both cases.

H323Plus is a continuation of OpenH323 (as is OPAL of course), so, I really don't know what the problem is if chan_h323 stops using an older and deprecated library that is not developed any more. All we would have to do is install and compile H323Plus the same way we used to compile OpenH323...

H323Plus is actively developed, bugs are fixed and new features are being brought in all the time to support further development of chan_h323 which has remained stagnant for a long time now.

Unless I am missing some details here and I may be completely missing the point I'd really like to know why we would need to stick to keep on supporting OpenH323...
By: Sergey Tamkovich (sergee) 2008-12-16 09:01:58.000-0600

> Does anyone object that chan_h323 does not support OpenH323 versions older than 1.18.0?

There is OpenH323 v  1.19.0, 1.19.0.1, etc I don't know the current status, but there was a time when chan_h323 would compile and work with those versions, without problems. Do you know why it is not recomended to use it? Beacuse there are tons of leaks and locks there, which weren't in 1.18.0.

The process of finding good combination of pwlib & openh323 was VERY painfull - in terms of money and realtions with customers, i don't want to go through it again. if you want new features - go ahead. But please keep chan_h323 compatable with open_h323 v 1.18.0, I hope Digium will pay enough attention to this question.
By: Sergey Tamkovich (sergee) 2008-12-16 09:04:31.000-0600

i don't care if it is developed or not. I care if it works or not. versions 1.19.0 and 1.19.0.1 are much worse then 1.18.0, so there is no guarantee that h323plus is better in any subject.
By: Vlasis Hatzistavrou (vhatz) 2008-12-16 12:10:04.000-0600

If we stick to older libraries which are not being maintained then chan_h323 will die at some point. H323 support is already seriously lacking compared to SIP and IAX in Asterisk, as we all know.

Having worked with various OpenH323 versions myself in production I can verify that similar if not the same leaks and locks existed in all the last OpenH323 versions till the project was renamed to OPAL, not just in the v1.19.xx versions. Just because v1.18 proved more successful in some aspects than v1.19.xx does this mean that we should not move forward?

H323Plus incorporates new features and fixes brought in from OPAL all the time. Things like higher call capacity, new codec negotiation algorithms and stability issues have been addressed already.

> versions 1.19.0 and 1.19.0.1 are much worse then 1.18.0, so there is no >guarantee that h323plus is better in any subject.

I fail to see the reasoning behind this. H323Plus is being maintained, OpenH323 is not. Which one has more chances to improve and fix problems?

I just believe that in the end, it all comes down to whether we want chan_h323 to improve and become comparable to chan_sip in terms of stability and functionality or if we want to let H323 support in Asterisk wither and die.


By: Jonathan Thurman (jthurman) 2009-02-25 16:49:25.000-0600

I modified h323p-14-r108926.diff for 1.6.0.6 and it successfully compiles.  While I can see why it would be nice to make a patch that is backwards compatible.  I don't have the time right now to create one, and do not require that functionality.  It was a pain enough to get h323plus to compile correctly without having to work about the ancient version.

Another options, that I would say is NOT a good idea, would be to move the h323plus code to the asterisk-addons package.

I would argue that it's time to move forward with the active project h323plus for this channel.
By: Digium Subversion (svnbot) 2009-03-17 15:47:33

Repository: asterisk
Revision: 182722

U   trunk/autoconf/ast_check_openh323.m4
U   trunk/channels/chan_h323.c
U   trunk/channels/h323/ast_h323.cxx
U   trunk/channels/h323/ast_h323.h
U   trunk/channels/h323/chan_h323.h
U   trunk/channels/h323/compat_h323.cxx
U   trunk/channels/h323/compat_h323.h
U   trunk/configure

------------------------------------------------------------------------
r182722 | jpeeler | 2009-03-17 15:47:32 -0500 (Tue, 17 Mar 2009) | 15 lines

Allow H.323 Plus library to be used in addition to the OpenH323 library

Chan_h323 can now be compiled against both the previously supported versions of
OpenH323 as well as the current H.323 Plus (version 1.20.2). The configure
script has been modified to look in the default install location of h323 to
hopefully help avoid using the environment variables OPENH323DIR and PWLIBDIR.
Also, the CLI command "h323 show version" has been added which indicates which
version of h323 is in use.

(closes issue ASTERISK-10778)
Reported by: vhatz
Patches:
     asterisk-1.6.0.6-h323plus.patch uploaded by jthurman (license 614)


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=182722
By: Digium Subversion (svnbot) 2009-03-17 15:51:06

Repository: asterisk
Revision: 182723

_U  branches/1.6.0/
U   branches/1.6.0/autoconf/ast_check_openh323.m4
U   branches/1.6.0/channels/chan_h323.c
U   branches/1.6.0/channels/h323/ast_h323.cxx
U   branches/1.6.0/channels/h323/ast_h323.h
U   branches/1.6.0/channels/h323/chan_h323.h
U   branches/1.6.0/channels/h323/compat_h323.cxx
U   branches/1.6.0/channels/h323/compat_h323.h
U   branches/1.6.0/configure

------------------------------------------------------------------------
r182723 | jpeeler | 2009-03-17 15:51:06 -0500 (Tue, 17 Mar 2009) | 21 lines

Merged revisions 182722 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r182722 | jpeeler | 2009-03-17 15:47:31 -0500 (Tue, 17 Mar 2009) | 15 lines
 
 Allow H.323 Plus library to be used in addition to the OpenH323 library
 
 Chan_h323 can now be compiled against both the previously supported versions of
 OpenH323 as well as the current H.323 Plus (version 1.20.2). The configure
 script has been modified to look in the default install location of h323 to
 hopefully help avoid using the environment variables OPENH323DIR and PWLIBDIR.
 Also, the CLI command "h323 show version" has been added which indicates which
 version of h323 is in use.
 
 (closes issue ASTERISK-10778)
 Reported by: vhatz
 Patches:
       asterisk-1.6.0.6-h323plus.patch uploaded by jthurman (license 614)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=182723
By: Digium Subversion (svnbot) 2009-03-17 15:52:55

Repository: asterisk
Revision: 182724

_U  branches/1.6.1/
U   branches/1.6.1/autoconf/ast_check_openh323.m4
U   branches/1.6.1/channels/chan_h323.c
U   branches/1.6.1/channels/h323/ast_h323.cxx
U   branches/1.6.1/channels/h323/ast_h323.h
U   branches/1.6.1/channels/h323/chan_h323.h
U   branches/1.6.1/channels/h323/compat_h323.cxx
U   branches/1.6.1/channels/h323/compat_h323.h
U   branches/1.6.1/configure

------------------------------------------------------------------------
r182724 | jpeeler | 2009-03-17 15:52:55 -0500 (Tue, 17 Mar 2009) | 21 lines

Merged revisions 182722 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r182722 | jpeeler | 2009-03-17 15:47:31 -0500 (Tue, 17 Mar 2009) | 15 lines
 
 Allow H.323 Plus library to be used in addition to the OpenH323 library
 
 Chan_h323 can now be compiled against both the previously supported versions of
 OpenH323 as well as the current H.323 Plus (version 1.20.2). The configure
 script has been modified to look in the default install location of h323 to
 hopefully help avoid using the environment variables OPENH323DIR and PWLIBDIR.
 Also, the CLI command "h323 show version" has been added which indicates which
 version of h323 is in use.
 
 (closes issue ASTERISK-10778)
 Reported by: vhatz
 Patches:
       asterisk-1.6.0.6-h323plus.patch uploaded by jthurman (license 614)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=182724
By: Digium Subversion (svnbot) 2009-03-17 15:53:56

Repository: asterisk
Revision: 182725

_U  branches/1.6.2/
U   branches/1.6.2/autoconf/ast_check_openh323.m4
U   branches/1.6.2/channels/chan_h323.c
U   branches/1.6.2/channels/h323/ast_h323.cxx
U   branches/1.6.2/channels/h323/ast_h323.h
U   branches/1.6.2/channels/h323/chan_h323.h
U   branches/1.6.2/channels/h323/compat_h323.cxx
U   branches/1.6.2/channels/h323/compat_h323.h
U   branches/1.6.2/configure

------------------------------------------------------------------------
r182725 | jpeeler | 2009-03-17 15:53:56 -0500 (Tue, 17 Mar 2009) | 21 lines

Merged revisions 182722 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

........
 r182722 | jpeeler | 2009-03-17 15:47:31 -0500 (Tue, 17 Mar 2009) | 15 lines
 
 Allow H.323 Plus library to be used in addition to the OpenH323 library
 
 Chan_h323 can now be compiled against both the previously supported versions of
 OpenH323 as well as the current H.323 Plus (version 1.20.2). The configure
 script has been modified to look in the default install location of h323 to
 hopefully help avoid using the environment variables OPENH323DIR and PWLIBDIR.
 Also, the CLI command "h323 show version" has been added which indicates which
 version of h323 is in use.
 
 (closes issue ASTERISK-10778)
 Reported by: vhatz
 Patches:
       asterisk-1.6.0.6-h323plus.patch uploaded by jthurman (license 614)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=182725