| Summary: | ASTERISK-10766: Ending recording with DTMF cuts off end of stream too early | ||
| Reporter: | Simon Kirby (sim) | Labels: | |
| Date Opened: | 2007-11-14 13:46:24.000-0600 | Date Closed: | 2007-11-14 17:59:15.000-0600 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | As noted especially with Meetme(|I) where recording of meetme member names is supported, ast_play_and_record() appears to be cutting off the end of the recorded stream much earlier than when the "#" is received to end recording. The effect is that people who are trying to be courteous with removing silence with "#" end up cutting off the end of their recording instead. Note this line in app/main.c: ast_stream_rewind(others[x], totalsilence ? totalsilence - 200 : 200); My understanding is that this leaves 200ms of silence if silence is detected, or chops off 200ms if no silence is detected. If so, I would suggest we change the last number to 0 or something close to it, so as to not throw away non-silent audio. It seems that this logic in app/main.c has remained unchanged for some time. According to svn annotate, markster submitted this in rev 3801 but perhaps it was moved from another file. The code has remained unchanged since other than some formatting changes. | ||
| Comments: | By: Digium Subversion (svnbot) 2007-11-14 17:21:50.000-0600 Repository: asterisk Revision: 89275 U branches/1.4/main/app.c ------------------------------------------------------------------------ r89275 | tilghman | 2007-11-14 17:21:49 -0600 (Wed, 14 Nov 2007) | 5 lines When a recording ends with '#', we are improperly trimming an extra 200ms from the recording. Reported by: sim Patch by: tilghman Closes issue ASTERISK-10766 ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-11-14 17:59:15.000-0600 Repository: asterisk Revision: 89276 _U trunk/ U trunk/main/app.c ------------------------------------------------------------------------ r89276 | tilghman | 2007-11-14 17:59:14 -0600 (Wed, 14 Nov 2007) | 13 lines Merged revisions 89275 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r89275 | tilghman | 2007-11-14 17:23:58 -0600 (Wed, 14 Nov 2007) | 5 lines When a recording ends with '#', we are improperly trimming an extra 200ms from the recording. Reported by: sim Patch by: tilghman Closes issue ASTERISK-10766 ........ ------------------------------------------------------------------------ | ||