| Summary: | ASTERISK-10745: [patch] add 'concise' option to sip show channels | ||
| Reporter: | Corey Edwards (tensai) | Labels: | |
| Date Opened: | 2007-11-12 14:56:48.000-0600 | Date Closed: | 2007-11-15 09:26:55.000-0600 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) consice-formats.txt ( 1) sip_show_channels_concise.patch | |
| Description: | This patch adds a 'concise' option to sip show channels and sip show subscriptions, modeled after the 'concise' option to core show channels. | ||
| Comments: | By: Eliel Sardanons (eliel) 2007-11-13 14:55:10.000-0600 I think we should add in a doc/ file what info shows every column on a concise command. By: Corey Edwards (tensai) 2007-11-14 11:22:56.000-0600 I just took whatever fields where in the existing output and displayed them without any length limits. Not a bad idea to have them documented though. I don't see that core show channels concise is documented anywhere so I've written it up as well. Some of the fields I'm not familiar enough to describe, so I could use a little help with them. I've left them in the list just as they are in the code. By: Olle Johansson (oej) 2007-11-15 04:48:22.000-0600 Well, you really should use the manager interface for parseable output. I don't like adding a lot of "concise" stuff to the CLI. We need a general discussion on asterisk-dev before we accept this - should we deprecate the "concise" version or go ahead and duplicate all CLI commands and make the code more hard to manage? By: Olle Johansson (oej) 2007-11-15 09:25:54.000-0600 We've had a discussion on the asterisk-dev mailing list and decided to deprecate the "show concise" in favour of the AMI. Now we need scripts to replace this functionality. Thank you for your patch, anyway. Contribution moves us forward, in this case not with your patch, but instead with a new design. /O | ||