[Home]

Summary:ASTERISK-10730: [patch] Change free() to ast_free()
Reporter:Eliel Sardanons (eliel)Labels:
Date Opened:2007-11-09 14:44:52.000-0600Date Closed:2007-12-12 14:02:47.000-0600
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast_free.patch
( 1) ast_free2.patch
Description:Use ast_free() instead of free();
Comments:By: Jason Parker (jparker) 2007-11-09 15:56:12.000-0600

As far as I know, ast_free should only be used with the ast_* memory allocation functions.  Did you have this in mind while writing this patch?  Some of the uses may be invalid (I haven't checked)
By: Eliel Sardanons (eliel) 2007-11-09 16:10:38.000-0600

I will review it again
By: Tilghman Lesher (tilghman) 2007-11-11 10:48:33.000-0600

In fact, the changes to main/utils.c are invalid.  If you start using the ast_ memory wrappers on internal thread management routines, you could create an infinite loop.
By: Digium Subversion (svnbot) 2007-12-12 14:02:47.000-0600

Repository: asterisk
Revision: 92594

U   trunk/apps/app_dial.c
U   trunk/apps/app_mixmonitor.c
U   trunk/main/logger.c
U   trunk/main/utils.c

------------------------------------------------------------------------
r92594 | tilghman | 2007-12-12 14:02:46 -0600 (Wed, 12 Dec 2007) | 5 lines

Conversions of free to ast_free, where applicable, and several other formatting fixes.
Reported by: eliel
Patch by: eliel,tilghman
(Closes issue ASTERISK-10730)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=92594