[Home]

Summary:ASTERISK-10729: [patch] Some deadlocks while loading config
Reporter:Tomás Laureano Peralta Tormey (laureano)Labels:
Date Opened:2007-11-09 09:54:05.000-0600Date Closed:2007-11-09 10:30:04.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:CDR/cdr_sqlite3_custom
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) cdr_sqlite3_custom.c.patch
Description:While reloading the config file, a deadlock could ocurr if any of the following errors are present in the config file:
- No "[master]" context defined.
- Column names not specified.
- Values not specified.

This patch prevents this deadlocks.

Disclaimer on file.

Also, the sample config file is named "cdr_sqlite3_custom.conf" and isn't copied when running make samples. Should be renamed to "cdr_sqlite3_custom.conf.sample".

****** STEPS TO REPRODUCE ******

For example, define the [master] context and load the module:
- Rename the context to something different (like [master1]),
- Reload the module,
- Rename the context to something different (like [master2]),
- Rename the module,
- Run "core show locks" command (if possible).
Comments:By: Digium Subversion (svnbot) 2007-11-09 10:30:04.000-0600

Repository: asterisk
Revision: 89130

U   trunk/cdr/cdr_sqlite3_custom.c
D   trunk/configs/cdr_sqlite3_custom.conf
A   trunk/configs/cdr_sqlite3_custom.conf.sample

------------------------------------------------------------------------
r89130 | qwell | 2007-11-09 10:30:03 -0600 (Fri, 09 Nov 2007) | 5 lines

Fix a few potential deadlocks in cdr_sqlite3_custom.
(also rename sample config to .sample)

Closes issue ASTERISK-10729, patch by Laureano.

------------------------------------------------------------------------