[Home]

Summary:ASTERISK-10725: when IMAP storage is enabled, a duplicate "regular" email is sent when no email account is specified
Reporter:Simon P. Ditner (spditner)Labels:
Date Opened:2007-11-08 17:40:44.000-0600Date Closed:2007-11-26 09:48:09.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 11204.patch
Description:When IMAP storage is enabled, and no email address is specified in the voicemail.conf, app_voicemail.c copies the IMAP username into the email field of a datastructure, thus accidentally triggering an email to be sent by some other part of the application.

See:
apps/app_voicemail.c, line 2323
if (ast_strlen_zero(vmu->email))
     ast_copy_string(vmu->email, vmu->imapuser, sizeof(vmu->email));

e.g. voicemail.conf

[general]
imapserver=localhost
imapfolder=inbox
imapflags=notls

[default]
123 => 111,Some Person,,,imapuser=some|imappassword=person
Comments:By: Mark Michelson (mmichelson) 2007-11-08 18:48:38.000-0600

I've uploaded 11204.patch for testing. Let me know if it solves the problem.

Thanks for reporting this, and double thanks for taking the time to comb the source to create such a good bug report!
By: Mark Michelson (mmichelson) 2007-11-15 17:07:29.000-0600

Any luck so far?
By: Simon P. Ditner (spditner) 2007-11-23 10:58:49.000-0600

Yes, it appears to work correctly now. Thanks!
By: Digium Subversion (svnbot) 2007-11-26 09:45:39.000-0600

Repository: asterisk
Revision: 89580

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r89580 | mmichelson | 2007-11-26 09:45:38 -0600 (Mon, 26 Nov 2007) | 6 lines

Revert vmu->email back to an empty string if it was empty when imap_store_file
was called. This prevents sending a duplicate e-mail.

(closes issue ASTERISK-10725, reported by spditner, patched by me)


------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-26 09:48:09.000-0600

Repository: asterisk
Revision: 89581

_U  trunk/
U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r89581 | mmichelson | 2007-11-26 09:48:09 -0600 (Mon, 26 Nov 2007) | 14 lines

Merged revisions 89580 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89580 | mmichelson | 2007-11-26 09:48:06 -0600 (Mon, 26 Nov 2007) | 6 lines

Revert vmu->email back to an empty string if it was empty when imap_store_file
was called. This prevents sending a duplicate e-mail.

(closes issue ASTERISK-10725, reported by spditner, patched by me)


........

------------------------------------------------------------------------